Skip to content

Benle/feat/bmc#55

Merged
benle7 merged 2 commits intodprital:master_sonic_sn5110_ldfrom
benle7:benle/feat/bmc
Aug 14, 2025
Merged

Benle/feat/bmc#55
benle7 merged 2 commits intodprital:master_sonic_sn5110_ldfrom
benle7:benle/feat/bmc

Conversation

@benle7
Copy link
Copy Markdown
Collaborator

@benle7 benle7 commented Aug 14, 2025

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@benle7 benle7 merged commit 0529cbb into dprital:master_sonic_sn5110_ld Aug 14, 2025
1 check passed
dprital pushed a commit that referenced this pull request Sep 18, 2025
…ically (sonic-net#23843)

#### Why I did it
src/sonic-dash-ha
```
* a680530 - (HEAD -> master, origin/master, origin/HEAD) Route exchange (#55) (2 days ago) [yue-fred-gao]
* e205d4d - Convert Unspecified to Standby in DashHaScopeTable. (sonic-net#97) (2 days ago) [dypet]
* 557fe19 - Fix producer bridge CI issue (sonic-net#105) (3 days ago) [yue-fred-gao]
```
#### How I did it
#### How to verify it
#### Description for the changelog
dprital pushed a commit that referenced this pull request Oct 12, 2025
…sonic-net#24099)

#### Why I did it
src/dhcpmon
```
* 5636443 - (HEAD -> master, origin/master, origin/HEAD) Add packet length check when receiving a packet (#55) (23 hours ago) [Yanpeng Zhang]
```
#### How I did it
#### How to verify it
#### Description for the changelog
liat-grozovik pushed a commit that referenced this pull request Jan 29, 2026
The following are the changes to get the modules compile:

  * Update `probe` function signature in the `i2c_driver instance dropping
    `i2c_device_id` parameter. This parameter is mostly unused in the probe
    function, if used, can be derived from the passed client pointer.
  * Remove `llseek` assignment to `no_llseek` in `file_operations`.
  * Remove `I2C_CLASS_SPD` attribute added by the modules.
  * Add missing import to `PMBUS` namespace.
  * Update `remove` function signature in the `platform_driver` and `pci_driver`
    instances, dropping return values.
  * Update `i2c_mux_add_adapter` args, dropping more than 3 args, if passed.
  * Fix `-Wint-conversion` errors occurring when `resource_size_t` is set to
    `NULL` instead of `0`.
  * Replace `strlcpy` with `strscpy`.

The following changes are done to align with trixie build (and other platforms):

  * Remove `debian/compat` file.
  * Update compat level to 13 and kernel version in `debian/control`.
  * Update `debian/rules` to use `pybuild` for non-PDDF modules and the
    conventional wheel package build for the PDDF modules. Also set shell option to
    exit upon encountering error.
  * Cleanup copying of wheel package in non-PDDF modules as the scripts are
    installed as part of debian package.
  * Make wheel package available under `build-<mod>` instead of under `modules`.

The changes are tested by building the platform packages through invoking the
below command:

  `make NOBUSTER=1 NOBULLSEYE=1 NOBOOKWORM=1 target/debs/trixie/platform-modules-dx010_1.0_amd64.deb`

Additionally, with further changes to rebranding of platform (not part of this
commit, will be raised separately) and skipping inclusion of other platforms,
verified install/boot of the `sonic-broadcom.bin` on a `DS3000` unit.

platform-celestica: config and script fixes for pddf init (#55)

The following fixes applicable to platforms (ds1000, ds2000, ds3000,
ds4000/silverstone-v2) for correct pddf intialization and access of platform
devices:

  * Update pddf-device json eliminating the need for additional indexing,
    multiplication operations in raw ipmi get.
  * The PDDF infra expects `num_components` as part of json config, update the
    same.
  * The ASIC PCIe firmware version uses `bcmcmd` to fetch the version. However,
    when syncd is not running, the error string is reported as version, fix this
    by return version as `Unknown` instead.
  * The PDDF component init passes pddf_data and pddf_plugin_data parameters,
    accommodate this.
  * Lookup correct overridden fan names from the PDDF plugin data accommodating
    fantray/psu and fan indices.
  * Lookup correct overridden thermal names from the PDDF plugin data.
  * Update platform specific monitoring service to start after `pddf-platform-init`
    service as this service imports `sonic_platform` module.
  * Update references of `/sys/class/i2c-adapter` to `/sys/bus/i2c/devices`
    instead.

Tested these changes on ds1000, ds2000, ds3000 and silverstone-v2 platforms with
accessing platform commands querying PDDF components. Verified that the accesses
to the components are ok.

Co-authored-by: Ramasamy Chandramouli <rachandr@celestica.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant