Skip to content

Detect old version of MacOS in MacCatalyst test runs#495

Merged
premun merged 4 commits intodotnet:mainfrom
premun:prvysoky/macos-version
Mar 11, 2021
Merged

Detect old version of MacOS in MacCatalyst test runs#495
premun merged 4 commits intodotnet:mainfrom
premun:prvysoky/macos-version

Conversation

@premun
Copy link
Member

@premun premun commented Mar 4, 2021

I found out that test apps built in dotnet/runtime require MacOS 10.15.6 minimum. We have that on most machines but DCI-MAC-BUILD-184 didn't have this, it was on 10.15.4 (which is a problem on its own).

I added a human readable message to catch this.

@premun premun requested a review from akoeplinger March 4, 2021 11:52
@premun
Copy link
Member Author

premun commented Mar 4, 2021

@akoeplinger, surprisingly, I can run the HelloiOS on 10.15.4 but not the BCL test apps.

Copy link
Contributor

@mandel-macaque mandel-macaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That nl thing.. I don't know if I love it or hate it.

@premun premun merged commit 692728b into dotnet:main Mar 11, 2021
@premun premun deleted the prvysoky/macos-version branch March 11, 2021 12:53
premun added a commit that referenced this pull request Mar 17, 2021
* Add triggers for xcode/* branches (#450)

* Remove dead code around TestRunner argument passing (#449)

- I compared what we send to and what we receive from the TestRunner EntryPoint and noticed quite a bit of unused options. These are remnants of the Xamarin code with which we don't share the EntryPoint anymore
- We are passing arguments both via env variables and arguments so we will only pass the env vars now
- There was a bug in the definition of the `class` argument and it wasn't parsed properly
- Another thing I fixed are the "extra" arguments - I don't they they were working until know because we prepend them with a `-app-arg:` prefix which is only recognized in the Xamarin's mono Main

* Improve various logging (#463)

Side effects of other work, related to #358

* Fail faster when cannot find any devices/emulators (#469)

* fail faster when cannot find any devices/emulators

* Apply suggestions from code review

Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>

Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>

* Move to new location of netcorenativeassets (#471)

* Remove the DummyTestProject (#472)

* Add support for the MacCatalyst target (#464)

- Adds support for the `apple test -t=maccatalyst` command (resolves #435)
- Getting system logs for the process is not working at the moment (#459)
- The `apple run` command cannot detect exit code yet (#462)

* Capture System.log when running MacCatalyst apps (#474)

Resolves #459

* Make sure the MacCatalyst app's binary is executable (#475)

* Allow to skip device-id for android install/run/uninstall (#479)

* allow to skip device-id for android install/run/uninstall if device can be choosed unambiguously

* Update src/Microsoft.DotNet.XHarness.Android/AdbRunner.cs

Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>

* addressed review feedback

Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>

* Update dependencies from https://github.com/dotnet/arcade build 20210225.5 (#482)

[main] Update dependencies from dotnet/arcade

* Run MacCatalyst via `open w` and detect exit code from logs (#484)

Resolves #462

* Add integration tests for MacCatalyst (#487)

* Add integration tests for the MacCatalyst target
* Make Helix tests run on local
* Remove EnableXUnitReporter
* Create template proj for integration tests

* Display the name of the exit code (#488)

* Wait for MacCatalyst system.log flush (#490)

* Don't reset the stream if we got a partial message (#489)

Fixes #473

* Do not report LaunchFailure when the app connected over TCP (#491)

* [wasm] add `--expected-exit-code` for `wasm test-browser`, similar to (#492)

.. what `wasm test` has.

* Rename iOS namespace to Apple (#494)

* Merge SimulatorInstaller commands to main CLI (#497)

This removes the SimulatorInstaller project and moves the file to CLI so that you can do:
```
xharness apple simulators list
```

When installing the simulators, it doesn't accept the same format e.g. `ios-simulator-64` of targets as the CLI, this will be a follow-up.

#478

* [wasm] Ensure that Safari/firefox drivers are Disposed in case of (#500)

.. failures. This manifested when running with Safari, and it doesn't
have `remote automation` enabled. That would cause xharness to get
stuck because of the still running driver process.

```
crit: System.InvalidOperationException: Could not create a session: You must enable the 'Allow Remote Automation' option in Safari's Develop menu to control Safari via WebDriver. (SessionNotCreated)
         at OpenQA.Selenium.Remote.RemoteWebDriver.UnpackAndThrowOnError(Response errorResponse)
         at OpenQA.Selenium.Remote.RemoteWebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
         at OpenQA.Selenium.Remote.RemoteWebDriver.StartSession(ICapabilities desiredCapabilities)
         at OpenQA.Selenium.Remote.RemoteWebDriver..ctor(ICommandExecutor commandExecutor, ICapabilities desiredCapabilities)
         at OpenQA.Selenium.Safari.SafariDriver..ctor(SafariDriverService service, SafariOptions options, TimeSpan commandTimeout)
         at Microsoft.DotNet.XHarness.CLI.Commands.Wasm.WasmTestBrowserCommand.GetSafariDriver(ILogger logger) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs:line 98
         at Microsoft.DotNet.XHarness.CLI.Commands.Wasm.WasmTestBrowserCommand.InvokeInternal(ILogger logger) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/WASM/Browser/WasmTestBrowserCommand.cs:line 63
         at Microsoft.DotNet.XHarness.Common.CLI.Commands.XHarnessCommand.Invoke(IEnumerable`1 arguments) in /_/src/Microsoft.DotNet.XHarness.Common/CLI/Commands/XHarnessCommand.cs:line 120
XHarness exit code: 71 (GENERAL_FAILURE)
XHarness artifacts: ./xharness-output
```

* [wasm][test-browser] Add `--browser-path` to use custom browser paths (#501)

* Detect old version of MacOS in MacCatalyst test runs (#495)

* Add base entry point class for android tests (#454)

* add base instrumentation class for android tests

* Update src/Microsoft.DotNet.XHarness.InstrumentationBase.Xunit/Microsoft.DotNet.XHarness.InstrumentationBase.Xunit.csproj

Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>

* review feedback 

* Update src/Microsoft.DotNet.XHarness.InstrumentationBase.Xunit/AndroidInstrumentationBase.cs

Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

* addressed review feedback

* remove instrumentation part, leave only default test entry point for android

* address review feedback

* remove test project

Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

* Fix CLI behavior when doing `xharness` or `xharness help` (#504)

* [main] Update dependencies from dotnet/arcade (#499)

[main] Update dependencies from dotnet/arcade


 - Merge remote-tracking branch 'origin/main' into darc-main-37ceeb7c-81af-4535-a6eb-96fcd2db6c28

 - Merge remote-tracking branch 'origin/main' into darc-main-37ceeb7c-81af-4535-a6eb-96fcd2db6c28

 - Update unit tests project to net6.0

* Fix possible merge mistake.

* Revert performance-setup.sh

Co-authored-by: Přemek Vysoký <premek.vysoky@microsoft.com>
Co-authored-by: Katya Sokolova <esokolov@microsoft.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants