Merged
Conversation
pavelsavara
approved these changes
Mar 12, 2026
kotlarmilos
pushed a commit
to kotlarmilos/xharness
that referenced
this pull request
Mar 16, 2026
kotlarmilos
pushed a commit
to kotlarmilos/xharness
that referenced
this pull request
Mar 16, 2026
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #1558
Root cause: The Arcade SDK v11.0.0-beta.26156.2 sets $(NetPrevious) to empty (because NetMinimum and NetPrevious would be identical at net10.0). The CLI project's TargetFrameworks expanded to net11.0;;net10.0 — the empty entry caused the .NET SDK to fail to generate DotnetToolSettings.xml properly.
Fix: Updated the TargetFrameworks in both affected projects to conditionally include $(NetPrevious) only when it's non-empty:
Microsoft.DotNet.XHarness.CLI.csproj:6-7 — the main tool project
Microsoft.DotNet.XHarness.DefaultAndroidEntryPoint.Xunit.csproj:4-5 — same pattern
The package now builds and packs successfully with DotnetToolSettings.xml present for both net10.0 and net11.0.