[apple] [infra] Refactor unification of app and main logs for iOS devices and MacCatalyst#1383
Conversation
- Move the logic of unifying the app and main logs to the TestOrchestrator. - Copy system and application logs to the main log after the app has finished.
ivanpovazan
left a comment
There was a problem hiding this comment.
I think this is OK and thanks for the fix.
One thing to consider is putting the log merging behind a CLI parameter which is not enabled by default, but rather from our testing infra.
Yes, that is more work, but what I found "annoying" is that now when you run a test/app from command line on Android the terminal gets polluted with the whole adb logcat output. From UX perspective we don't want that and should at least provide a way to turn it off.
/cc: @akoeplinger for thoughts
src/Microsoft.DotNet.XHarness.Apple/Orchestration/TestOrchestrator.cs
Outdated
Show resolved
Hide resolved
…ator.cs Co-authored-by: Ivan Povazan <55002338+ivanpovazan@users.noreply.github.com>
That's a very good point, one that I haven't considered much before. I think we could add it as |
…touskozak/xharness into refactor-log-unification-apple-mobile
|
fyi: moved the log merging after the |
akoeplinger
left a comment
There was a problem hiding this comment.
LGTM. I agree we should add the CLI option for opting-in
|
/ba-g failure is a known issue |
…ices and MacCatalyst (dotnet#1383) - Move the logic of unifying the app and main logs to the TestOrchestrator. - Copy system and application logs to the main log after the app has finished.
Refactor unification of app and main logs for iOS devices and MacCatalyst :
Example of refactored reporting: https://helixr1107v0xdeko0k025g8.blob.core.windows.net/dotnet-xharness-refs-pull-1383-merge-253e93d337aa4abdbb/tvos-device-System.Buffers.Tests.app/1/console.f4e82d5e.log?helixlogtype=result
Possibly fixing #1382