Skip to content

Update TFM from .net7.0 to .net8.0#7219

Merged
dipeshmsft merged 4 commits intomainfrom
net7tonet8
Oct 25, 2022
Merged

Update TFM from .net7.0 to .net8.0#7219
dipeshmsft merged 4 commits intomainfrom
net7tonet8

Conversation

@rchauhan18
Copy link
Contributor

@rchauhan18 rchauhan18 commented Oct 20, 2022 •
edited by ghost
Loading

Update TFM from .net7.0 to .net8.0

Microsoft Reviewers: Open in CodeFlow

@rchauhan18 rchauhan18 requested a review from a team as a code owner October 20, 2022 08:28
@ghost ghost assigned rchauhan18 Oct 20, 2022
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Oct 20, 2022
@ghost ghost requested review from dipeshmsft and singhashish-wpf October 20, 2022 08:28
@ThomasGoulet73 ThomasGoulet73 mentioned this pull request Oct 23, 2022
Merged
@RussKie
Copy link
Contributor

RussKie commented Oct 23, 2022 

D:\a\_work\1\s\.dotnet\sdk\8.0.100-alpha.1.22512.5\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(267,5): error NETSDK1005: Assets file 'D:\a\_work\1\s\artifacts\obj\PresentationBuildTasks\project.assets.json' doesn't have a target for 'net8.0'. Ensure that restore has run and that you have included 'net8.0' in the TargetFrameworks for your project. [D:\a\_work\1\s\src\Microsoft.DotNet.Wpf\src\PresentationBuildTasks\PresentationBuildTasks.csproj::TargetFramework=net8.0]
##[error].dotnet\sdk\8.0.100-alpha.1.22512.5\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(267,5): error NETSDK1005: (NETCORE_ENGINEERING_TELEMETRY=Build) Assets file 'D:\a\_work\1\s\artifacts\obj\PresentationBuildTasks\project.assets.json' doesn't have a target for 'net8.0'. Ensure that restore has run and that you have included 'net8.0' in the TargetFrameworks for your project.

dipeshmsft
dipeshmsft requested changes Oct 25, 2022
View reviewed changes
Copy link
Member

@dipeshmsft dipeshmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will have to change TFM to net8.0 in PresentationBuildTasks.csproj

wpf/src/Microsoft.DotNet.Wpf/src/PresentationBuildTasks/PresentationBuildTasks.csproj

Lines 2 to 4 in 89620aa

<PropertyGroup>
<TargetFrameworks>net472;net7.0</TargetFrameworks>
<EnableDefaultItems>false</EnableDefaultItems>

@ghost ghost added the 📭 waiting-author-feedback To request more information from author. label Oct 25, 2022
@ghost ghost removed the 📭 waiting-author-feedback To request more information from author. label Oct 25, 2022
@dipeshmsft dipeshmsft merged commit 368f0e8 into main Oct 25, 2022
@dipeshmsft dipeshmsft deleted the net7tonet8 branch October 25, 2022 10:49
singhashish-wpf pushed a commit that referenced this pull request Nov 1, 2022
@rchauhan18 @singhashish-wpf
Update TFM from .net7.0 to .net8.0 (#7219)
b725339 
* Update TFM from .net7.0 to .net8.0

* Updated global.json

* Update SdkReferences.targets

* Update PresentationBuildTasks
@ghost ghost locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dipeshmsft dipeshmsft dipeshmsft approved these changes

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

+1 more reviewer

@RussKie RussKie RussKie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rchauhan18 rchauhan18

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rchauhan18 @RussKie @dipeshmsft