Fix the stream do not be closed in ImageSourceTypeConverter#7091
Merged
dipeshmsft merged 1 commit intodotnet:mainfrom Oct 26, 2022
Merged
Conversation
src/Microsoft.DotNet.Wpf/src/ReachFramework/Serialization/ImageSourceTypeConverter.cs
Outdated
Show resolved
Hide resolved
50aa5a7 to
3b83172
Compare
anjaligupta-dev
approved these changes
Oct 3, 2022
Member
|
@lindexi , thanks for the contribution |
Member
Author
|
Thank you @dipeshmsft |
singhashish-wpf
pushed a commit
that referenced
this pull request
Nov 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6842
Description
The ImageSourceTypeConverter will request the stream. And the ImageSourceTypeConverter will close the stream after
CopyImageStreammethod. But the stream will not be closed when theCopyImageStreamthrow the exception.This will make the ZipArchiveEntry throw the
System.IO.IOException: 'Entries cannot be opened multiple times in Update mode.'when we next time to request the stream.Customer Impact
Maybe this can fix #6842
Regression
None.
Testing
Just CI
Risk
Very low?
Microsoft Reviewers: Open in CodeFlow