Skip to content

Replace resource constants with properties in PresentationBuildTasks#7000

Merged
dipeshmsft merged 3 commits intodotnet:mainfrom
ThomasGoulet73:replace-resource-constants-with-properties-presentationbuildtasks
Oct 26, 2022
Merged

Replace resource constants with properties in PresentationBuildTasks#7000
dipeshmsft merged 3 commits intodotnet:mainfrom
ThomasGoulet73:replace-resource-constants-with-properties-presentationbuildtasks

Conversation

@ThomasGoulet73
Copy link
Contributor

@ThomasGoulet73 ThomasGoulet73 commented Sep 1, 2022

Contributes to #1

Description

Replace the use of resource constants with properties in PresentationBuildTasks. This follows the standard of other .Net projects, like dotnet/runtime.

Customer Impact

None.

Regression

No.

Testing

Local build + CI.

Risk

None.

Microsoft Reviewers: Open in CodeFlow

@ThomasGoulet73 ThomasGoulet73 requested a review from a team as a code owner September 1, 2022 01:18
@ghost ghost assigned ThomasGoulet73 Sep 1, 2022
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Sep 1, 2022
@ghost ghost requested review from SamBent, dipeshmsft and singhashish-wpf September 1, 2022 01:18
@ghost ghost added the Community Contribution A label for all community Contributions label Sep 1, 2022
@singhashish-wpf
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@lindexi
Copy link
Member

lindexi commented Sep 7, 2022

Awesome!

@dipeshmsft
Copy link
Member

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

…ource-constants-with-properties-presentationbuildtasks
@pchaurasia14
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@dipeshmsft dipeshmsft merged commit b421f0c into dotnet:main Oct 26, 2022
@ThomasGoulet73 ThomasGoulet73 deleted the replace-resource-constants-with-properties-presentationbuildtasks branch October 26, 2022 15:01
@ThomasGoulet73
Copy link
Contributor Author

Thank you @dipeshmsft

singhashish-wpf pushed a commit that referenced this pull request Nov 1, 2022
…#7000)

Contributes to #1

Co-authored-by: Dipesh Kumar <85861525+dipeshmsft@users.noreply.github.com>
@ghost ghost locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants