Skip to content

Replace resource constants with properties in PresentationUI#6889

Merged
dipeshmsft merged 1 commit intodotnet:mainfrom
ThomasGoulet73:replace-resource-constants-with-properties-presentationui
Oct 26, 2022
Merged

Replace resource constants with properties in PresentationUI#6889
dipeshmsft merged 1 commit intodotnet:mainfrom
ThomasGoulet73:replace-resource-constants-with-properties-presentationui

Conversation

@ThomasGoulet73
Copy link
Contributor

@ThomasGoulet73 ThomasGoulet73 commented Aug 12, 2022

Contributes to #1

Description

Replace the use of resource constants with properties in PresentationUI. This follows the standard of other .Net projects, like dotnet/runtime.

Customer Impact

None.

Regression

No.

Testing

Local build + CI.

Risk

None.

Microsoft Reviewers: Open in CodeFlow

@ThomasGoulet73 ThomasGoulet73 requested a review from a team as a code owner August 12, 2022 01:33
@ghost ghost assigned ThomasGoulet73 Aug 12, 2022
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Aug 12, 2022
@ghost ghost requested review from SamBent, dipeshmsft and singhashish-wpf August 12, 2022 01:33
@ghost ghost added the Community Contribution A label for all community Contributions label Aug 12, 2022
@dipeshmsft
Copy link
Member

@ThomasGoulet73 , thanks for the contribution.

@ThomasGoulet73 ThomasGoulet73 deleted the replace-resource-constants-with-properties-presentationui branch October 26, 2022 15:01
@ThomasGoulet73
Copy link
Contributor Author

Thank you @dipeshmsft

@ghost ghost locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants