Fix NullReferenceException in Invariant.get_IsDialogOverrideEnabled#6785
Merged
dipeshmsft merged 3 commits intodotnet:mainfrom Oct 26, 2022
Conversation
…hen .NET Framework Registry key (HKLM\Software\Microsoft\.NETFramework) is not present on the machine dotnet#6772
Contributor
|
Is there a reason for splitting the declaration from assignment? |
Member
Can't think of a reason, I guess we should merge the declaration and assignment for both the variables. |
dipeshmsft
reviewed
Aug 31, 2022
dipeshmsft
requested changes
Aug 31, 2022
Member
dipeshmsft
left a comment
There was a problem hiding this comment.
Can you merge the declaration here and remove the declarations from Line 241-242
Co-authored-by: Dipesh Kumar <85861525+dipeshmsft@users.noreply.github.com>
Contributor
Author
Done. |
dipeshmsft
reviewed
Sep 3, 2022
dipeshmsft
approved these changes
Sep 10, 2022
Member
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
|
/azp run |
|
No pipelines are associated with this pull request. |
Member
|
Thanks for the contribution @VladimirKhil |
singhashish-wpf
pushed a commit
that referenced
this pull request
Nov 1, 2022
…6785) * Fix NullReferenceException in Invariant.get_IsDialogOverrideEnabled when .NET Framework Registry key (HKLM\Software\Microsoft\.NETFramework) is not present on the machine #6772 * Update src/Microsoft.DotNet.Wpf/src/Shared/MS/Internal/Invariant.cs Co-authored-by: Dipesh Kumar <85861525+dipeshmsft@users.noreply.github.com> * Remove unnecessary declarations Co-authored-by: Dipesh Kumar <85861525+dipeshmsft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6772
Description
Fix NullReferenceException in Invariant.get_IsDialogOverrideEnabled when .NET Framework Registry key (HKLM\Software\Microsoft.NETFramework) is not present on the machine
Customer Impact
Regression
Testing
Risk
Microsoft Reviewers: Open in CodeFlow