Skip to content

Using the Clone method to fast clone the array in StylusPoint#5218

Merged
singhashish-wpf merged 1 commit intodotnet:mainfrom
dotnet-campus:t/lindexi/CloneArrayStylusPoint
Jul 14, 2022
Merged

Using the Clone method to fast clone the array in StylusPoint#5218
singhashish-wpf merged 1 commit intodotnet:mainfrom
dotnet-campus:t/lindexi/CloneArrayStylusPoint

Conversation

@lindexi
Copy link
Member

@lindexi lindexi commented Aug 29, 2021

Description

Benchmark:

Method Mean Error StdDev Gen 0 Gen 1 Allocated
CopyByFor 765.7 ns 3.72 ns 3.11 ns 0.6409 0.0095 4 KB
CopyByArray 260.6 ns 3.39 ns 3.17 ns 0.6413 0.0095 4 KB
CopyByClone 250.3 ns 2.04 ns 1.70 ns 0.6390 0.0095 4 KB

Benchmark code: https://github.com/lindexi/lindexi_gd/tree/5aef1567e56bf2b8a67c21f94b18f9827c18aaf4/CejelfairqereKecelherwelka

Customer Impact

Regression

Testing

Just CI.

Risk

Low.

@lindexi lindexi requested a review from a team as a code owner August 29, 2021 13:00
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Aug 29, 2021
@ghost ghost requested review from SamBent, fabiant3 and ryalanms August 29, 2021 13:00
lindexi added a commit to lindexi/lindexi_gd that referenced this pull request Aug 29, 2021
@singhashish-wpf
Copy link
Contributor

@lindexi This PR is being considered for next community test pass.

@lindexi
Copy link
Member Author

lindexi commented Jul 8, 2022

Thank you @singhashish-wpf

@singhashish-wpf singhashish-wpf merged commit 9e77ce1 into dotnet:main Jul 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
@lindexi lindexi deleted the t/lindexi/CloneArrayStylusPoint branch November 9, 2023 06:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants