Skip to content

Using Array.Copy to make array copy faster in StylusPointCollection#5217

Merged
dipeshmsft merged 2 commits intodotnet:mainfrom
dotnet-campus:t/lindexi/StylusPointCollectionArray
Jan 3, 2022
Merged

Using Array.Copy to make array copy faster in StylusPointCollection#5217
dipeshmsft merged 2 commits intodotnet:mainfrom
dotnet-campus:t/lindexi/StylusPointCollectionArray

Conversation

@lindexi
Copy link
Member

@lindexi lindexi commented Aug 29, 2021 •
edited
Loading

Description

Benchmark:

Method start length Mean Error StdDev Gen 0 Gen 1 Allocated
CopyByFor 0 10 10.940 ns 0.0908 ns 0.0850 ns 0.0102 - 64 B
CopyByArray 0 10 9.861 ns 0.0784 ns 0.0655 ns 0.0102 - 64 B
CopyByFor 0 20 18.666 ns 0.2216 ns 0.2073 ns 0.0166 - 104 B
CopyByArray 0 20 13.494 ns 0.1908 ns 0.1785 ns 0.0166 - 104 B
CopyByFor 0 100 88.846 ns 0.5168 ns 0.4834 ns 0.0675 - 424 B
CopyByArray 0 100 32.594 ns 0.4785 ns 0.4476 ns 0.0675 0.0001 424 B
CopyByFor 10 10 10.966 ns 0.1215 ns 0.1136 ns 0.0102 - 64 B
CopyByArray 10 10 10.383 ns 0.1375 ns 0.1286 ns 0.0102 - 64 B
CopyByFor 10 20 18.866 ns 0.1972 ns 0.1844 ns 0.0166 - 104 B
CopyByArray 10 20 13.001 ns 0.1484 ns 0.1239 ns 0.0166 - 104 B
CopyByFor 10 100 88.808 ns 0.7298 ns 0.6826 ns 0.0675 - 424 B
CopyByArray 10 100 32.444 ns 0.5749 ns 0.5378 ns 0.0675 0.0001 424 B
CopyByFor 100 10 11.253 ns 0.1088 ns 0.1018 ns 0.0102 - 64 B
CopyByArray 100 10 9.738 ns 0.1242 ns 0.1162 ns 0.0102 - 64 B
CopyByFor 100 20 18.925 ns 0.3305 ns 0.2930 ns 0.0166 - 104 B
CopyByArray 100 20 13.211 ns 0.0924 ns 0.0819 ns 0.0166 - 104 B
CopyByFor 100 100 87.571 ns 0.5975 ns 0.5589 ns 0.0675 - 424 B
CopyByArray 100 100 35.169 ns 0.5966 ns 0.5581 ns 0.0675 0.0001 424 B

Benchmark code: https://github.com/lindexi/lindexi_gd/tree/07e92a85c104b760def5a87aac1c0e6c237311f5/CejelfairqereKecelherwelka

Customer Impact

Regression

Testing

Just CI.

Risk

Low.

@lindexi lindexi requested a review from a team as a code owner August 29, 2021 12:42
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Aug 29, 2021
@ghost ghost requested review from SamBent, fabiant3 and ryalanms August 29, 2021 12:42
lindexi added a commit to lindexi/lindexi_gd that referenced this pull request Aug 29, 2021
@lindexi
Test performance
07e92a8 
dotnet/wpf#5217
@anjaligupta-dev anjaligupta-dev self-assigned this Dec 12, 2021
@anjaligupta-dev anjaligupta-dev self-requested a review December 12, 2021 17:40
@dipeshmsft dipeshmsft merged commit 95c3da0 into dotnet:main Jan 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@ryalanms ryalanms Awaiting requested review from ryalanms

@SamBent SamBent Awaiting requested review from SamBent

2 more reviewers

@ThomasGoulet73 ThomasGoulet73 ThomasGoulet73 left review comments

@anjaligupta-dev anjaligupta-dev anjaligupta-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anjaligupta-dev anjaligupta-dev

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lindexi @ThomasGoulet73 @anjaligupta-dev @dipeshmsft