Skip to content

System.Windows.Markup.XamlParseException when reading resource file #5004

Merged
ryalanms merged 2 commits intomainfrom
pre.baml.resources
Aug 4, 2021
Merged

System.Windows.Markup.XamlParseException when reading resource file #5004
ryalanms merged 2 commits intomainfrom
pre.baml.resources

Conversation

@ryalanms
Copy link
Member

@ryalanms ryalanms commented Aug 4, 2021

The failure looks like an unintended consequence of #4799. The path incorrectly contains the filename of the application assembly. Reverting the change for now, since we are so close to snapping the release candidate for .NET 6.0.

Fixes issue #4987.

@ryalanms ryalanms requested a review from a team as a code owner August 4, 2021 19:03
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Aug 4, 2021
@ghost ghost requested review from SamBent and fabiant3 August 4, 2021 19:03
@ryalanms
Copy link
Member Author

ryalanms commented Aug 4, 2021

The scenario is an application built for .NET 3.1 that is running on a machine with only .NET 6.0 installed.

To repro, set the environment variable `DOTNET_ROLL_FORWARD_ON_NO_CANDIDATE_FX=2' or add the equivalent setting to the application's runtime.json file:

{
  "runtimeOptions": {
    "tfm": "netcoreapp3.1",
    "framework": {
      "name": "Microsoft.WindowsDesktop.App",
      "version": "3.1.0"
    },
    "rollForwardOnNoCandidateFx" : 2 
  }
}

@ryalanms ryalanms merged commit a49e7e2 into main Aug 4, 2021
@lindexi
Copy link
Member

lindexi commented Aug 5, 2021

@ryalanms Sorry

@ryalanms
Copy link
Member Author

ryalanms commented Aug 5, 2021

@ryalanms Sorry

Thank you for all your great work, @lindexi. We can get a modified version of this back in when we branch for 7.0.

@ryalanms ryalanms deleted the pre.baml.resources branch August 6, 2021 17:41
lindexi added a commit to dotnet-campus/wpf that referenced this pull request Aug 12, 2021
The Application.ResourceAssembly.CodeBase is the string without escaped.

See:

- dotnet#4781
- dotnet#5004
- dotnet#4799
lindexi added a commit to dotnet-campus/wpf that referenced this pull request Aug 12, 2021
The Application.ResourceAssembly.CodeBase is the string without escaped.

See:

- dotnet#4781
- dotnet#5004
- dotnet#4799
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants