Ensure the WindowsDesktopSdk RepoLocation overrides all others.#2366
Ensure the WindowsDesktopSdk RepoLocation overrides all others.#23661 commit merged intodotnet:masterfrom
Conversation
…is key to packaging PresentationBuildTasks and associated files.
|
|
||
| <!-- WindowsDesktopSdk overrides Internal, External etc. --> | ||
| <RepoLocation Condition="'$(RepoLocation)' == '' And $(WindowsDesktopSdkProject.Contains('$(NormalizedMSBuildProjectName)'))">WindowsDesktopSdk</RepoLocation> | ||
| <RepoLocation Condition="$(WindowsDesktopSdkProject.Contains('$(NormalizedMSBuildProjectName)'))">WindowsDesktopSdk</RepoLocation> |
There was a problem hiding this comment.
@vatsan-madhavan I was thinking of adding something here to specifically check for overriding internal or external, but I felt that was overkill and we always want the SDK to package properly.
|
Hello @rladuca! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Looks like the bot just up and merged this. @vatsan-madhavan if there are any comments you have on this I'll update with a new PR, for now I think this should just solve the immediate problem. |
|
Why was targets being picked up but not props - what makes props different? |
Nothing in PBT was packaged properly. If you look at the WindowsDesktop SDK package, you'll see everything PBT (including WinFX) was missing. They were landing in our private transport package. |
|
I just changed your code back and packaged it locally - windowsdesktop.nupkg built correctly for me. |
…is key to packaging PresentationBuildTasks and associated files. (#2366)
Fixes #2363
Ensure the WindowsDesktopSdk RepoLocation overrides all others. This is key to packaging PresentationBuildTasks and associated files.