Added unit tests for "AccessibleObject.FragmentNavigate" method in ToolStrip-related classes#8249
Merged
Tanya-Solyanik merged 4 commits intodotnet:mainfrom Dec 1, 2022
Conversation
…d duplicate items reordering. Fixed AccessibleObject.FragmentNavigate method to return null when control handle is not created.
...ndows.Forms/tests/UnitTests/System/Windows/Forms/MenuStrip.MenuStripAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/StatusStrip.StatusStripAccessibleObject.cs
Outdated
Show resolved
Hide resolved
...System/Windows/Forms/ToolStripDropDownButton.ToolStripDropDownButtonAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
70f8c7e to
bad1cdc
Compare
Contributor
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Looks good, I added a nitpick.
...tem.Windows.Forms/tests/UnitTests/System/Windows/Forms/ToolStripItemAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
...s/UnitTests/System/Windows/Forms/ToolStripOverflow.ToolStripOverflowAccessibleObjectTests.cs
Outdated
Show resolved
Hide resolved
d949137
bad1cdc to
d949137
Compare
dmitrii-drobotov
approved these changes
Dec 1, 2022
Tanya-Solyanik
approved these changes
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6094
Proposed changes
Added missing unit tests to check the method behavior in these classes:
This PR is a follow-up for #8248 that fixes buggy FragmentNavigate method in ToolStripAccessibleObject and it's subclasses. New unit tests verify the correct FragmentNavigate implementation.
Test environment(s)
Microsoft Reviewers: Open in CodeFlow