Skip to content

Fixed FragmentNavigate issue in ToolStripAccessibleObject#8248

Merged
Tanya-Solyanik merged 1 commit intodotnet:mainfrom
v-elnovikova:Issue_8033_Fixing_ToolStrip_ChildFragment
Nov 30, 2022
Merged

Fixed FragmentNavigate issue in ToolStripAccessibleObject#8248
Tanya-Solyanik merged 1 commit intodotnet:mainfrom
v-elnovikova:Issue_8033_Fixing_ToolStrip_ChildFragment

Conversation

@v-elnovikova
Copy link
Contributor

@v-elnovikova v-elnovikova commented Nov 22, 2022 •
edited
Loading

Fixes #8033

Proposed changes

  • Removed duplicate items reordering in GetChildFragment and GetChildFragmentIndex methods
  • Modified FragmentNavigate to return null if ToolStrip's handle is not created
  • Modified unit tests to properly follow handle creation

Screenshots

Before
before

After
after

Microsoft Reviewers: Open in CodeFlow

@v-elnovikova
Fixed ChildFragments calculation for ToolStrip-based controls: remove…
e3681f3 
…d duplicate items reordering. Fixed AccessibleObject.FragmentNavigate method to return null when control handle is not created.
@v-elnovikova v-elnovikova requested a review from a team as a code owner November 22, 2022 11:43
@ghost ghost assigned v-elnovikova Nov 22, 2022
@v-elnovikova v-elnovikova added the waiting-review This item is waiting on review by one or more members of team label Nov 22, 2022
dmitrii-drobotov
dmitrii-drobotov reviewed Nov 23, 2022
View reviewed changes
Copy link
Contributor

@dmitrii-drobotov dmitrii-drobotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dmitrii-drobotov dmitrii-drobotov mentioned this pull request Nov 24, 2022
Closed
28 tasks
@Tanya-Solyanik Tanya-Solyanik mentioned this pull request Nov 27, 2022
Merged
@Tanya-Solyanik Tanya-Solyanik merged commit 358c1a3 into dotnet:main Nov 30, 2022
@ghost ghost added this to the 8.0 Preview1 milestone Nov 30, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 30, 2022
@v-elnovikova v-elnovikova deleted the Issue_8033_Fixing_ToolStrip_ChildFragment branch May 25, 2023 08:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NikitaSemenovAkvelon NikitaSemenovAkvelon Awaiting requested review from NikitaSemenovAkvelon

@dkazennov dkazennov Awaiting requested review from dkazennov

2 more reviewers

@dmitrii-drobotov dmitrii-drobotov dmitrii-drobotov left review comments

@Tanya-Solyanik Tanya-Solyanik Tanya-Solyanik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v-elnovikova v-elnovikova

Labels

waiting-review This item is waiting on review by one or more members of team

Projects

None yet

Milestone

8.0 Preview1

Development

Successfully merging this pull request may close these issues.

[Accessibility] The menuItem with Alignment: right setting is not displayed in UIA tree when setting MenuStrip's GripStyle as Visible

3 participants

@v-elnovikova @Tanya-Solyanik @dmitrii-drobotov