Merged
Conversation
Historically our first four fields matched the layout of MSG. Keeping it that way for better back compat. As Message doesn't match MSG, they shouldn't be blitted over each other, but for those that might be doing this we can keep the order. Note that other future changes to the struct could break doing this sort of thing even if the first four fields stay the same.
dreddy-work
approved these changes
Oct 28, 2022
Member
|
I should have put a note to wait on merge. We should be good given branding is already made. TimeLine was from 1st NOV. Will keep an eye if we need to do somethign about this. |
Member
|
This one went into .NET 8. We'll need to cherry pick the changes for the 7.0.1 branch and add servicing consider tag to the actual bug. |
Contributor
|
@JeremyKuhne in the future please use GitHub keywords to establish cross-links between issues and pull requests. |
Member
Author
|
@RussKie I deliberately did not use the keyword in this case as I didn't want the issue automatically closed. |
Contributor
|
Closed issues can be reopened, The lack of cross-referencing affects ability to data-mine via Kusto queries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Historically our first four fields matched the layout of MSG. Keeping it that way for better back compat.
As Message doesn't match MSG, they shouldn't be blitted over each other, but for those that might be doing this we can keep the order. Note that other future changes to the struct could break doing this sort of thing even if the first four fields stay the same.
Fixes #8062
Relates to #5849
Microsoft Reviewers: Open in CodeFlow