Update AccessibilityApp as .Net 4.8.1 updated, fix GH issues: 7336, 7337, 7354#7359
Merged
dreddy-work merged 4 commits intodotnet:mainfrom Jul 5, 2022
Olina-Zhang:Update_AccessibilityApp
Merged
Update AccessibilityApp as .Net 4.8.1 updated, fix GH issues: 7336, 7337, 7354#7359dreddy-work merged 4 commits intodotnet:mainfrom Olina-Zhang:Update_AccessibilityApp
dreddy-work merged 4 commits intodotnet:mainfrom
Olina-Zhang:Update_AccessibilityApp
Conversation
RussKie
suggested changes
Jun 29, 2022
src/System.Windows.Forms/tests/AccessibilityTests/PrintingControls.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/AccessibilityTests/PrintingControls.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/AccessibilityTests/RemainingControls.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/AccessibilityTests/RemainingControls.Designer.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/AccessibilityTests/PrintingControls.Designer.cs
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Jun 29, 2022
Contributor
RussKie
left a comment
There was a problem hiding this comment.
Do the samples need to be localized? If not, please remove all the added xlf files.
Member
Author
Removed it, the app doesn't need. |
src/System.Windows.Forms/tests/AccessibilityTests/CommonControl1.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/AccessibilityTests/DataControls.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/AccessibilityTests/DataControls.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/AccessibilityTests/DialogControls.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/AccessibilityTests/DialogControls.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/AccessibilityTests/PrintingControls.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/tests/AccessibilityTests/PrintingControls.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
approved these changes
Jun 30, 2022
Contributor
Tanya-Solyanik
left a comment
There was a problem hiding this comment.
Thank you! Looks good!
dreddy-work
pushed a commit
that referenced
this pull request
Jul 7, 2022
…337, 7354 (#7359) * Update Accessibility app as .Net 4.8.1 updated, and fix GH issues: 7336 & 7337 * Updated * Remove xlf files * changes Co-authored-by: Igor Velikorossov <igveliko@microsoft.com>
dreddy-work
pushed a commit
that referenced
this pull request
Jul 7, 2022
…337, 7354 (#7359) * Update Accessibility app as .Net 4.8.1 updated, and fix GH issues: 7336 & 7337 * Updated * Remove xlf files * changes Co-authored-by: Igor Velikorossov <igveliko@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7336
Fixes #7337
Fixes #7354
Update Accessibility testing application as .Net 4.8.1 we did, and fix GH issues: #7336, #7337, #7354
Customer Impact
N/A
Regression?
No
Risk
No
Microsoft Reviewers: Open in CodeFlow