Skip to content

[main] Update dependencies from dotnet/runtime#6486

Merged
dotnet-maestro[bot] merged 1 commit intomainfrom
darc-main-a47f88e9-db23-440f-96df-c121efe48bfb
Jan 9, 2022
Merged

[main] Update dependencies from dotnet/runtime#6486
dotnet-maestro[bot] merged 1 commit intomainfrom
darc-main-a47f88e9-db23-440f-96df-c121efe48bfb

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 9, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: d9f5b309-084f-43b5-02de-08d8b80548e4
  • Build: 20220108.4
  • Date Produced: January 8, 2022 11:23:16 PM UTC
  • Commit: ce2165d8084cca98b95f5d8ff9386759bfd8c722
  • Branch: refs/heads/main
Microsoft Reviewers: Open in CodeFlow

…0108.4

Microsoft.Windows.Compatibility , Microsoft.Win32.SystemEvents , Microsoft.Win32.Registry.AccessControl , Microsoft.NETCore.Platforms , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.ILAsm , Microsoft.NETCore.App.Runtime.win-x64 , System.Drawing.Common , System.DirectoryServices , System.Diagnostics.PerformanceCounter , System.Diagnostics.EventLog , System.Configuration.ConfigurationManager , System.CodeDom , System.IO.Packaging , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Pkcs , System.Resources.Extensions , System.Reflection.MetadataLoadContext , runtime.win-x86.Microsoft.NETCore.ILAsm , runtime.win-x64.Microsoft.NETCore.ILAsm , Microsoft.NET.Sdk.IL , Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NETCore.App.Ref , System.Text.Encodings.Web , System.Windows.Extensions , System.Threading.AccessControl , System.Text.Json , VS.Redist.Common.NetCore.SharedFramework.x64.7.0
 From Version 7.0.0-alpha.1.22057.18 -> To Version 7.0.0-alpha.1.22058.4
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner January 9, 2022 13:07
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@dotnet-maestro dotnet-maestro bot merged commit 4cd87f4 into main Jan 9, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-a47f88e9-db23-440f-96df-c121efe48bfb branch January 9, 2022 13:42
Danil-Andrianov pushed a commit to Danil-Andrianov/winforms that referenced this pull request Jan 10, 2022
…0108.4 (dotnet#6486)

[main] Update dependencies from dotnet/runtime
WPMGPRoSToTeMa pushed a commit to WPMGPRoSToTeMa/winforms that referenced this pull request Jan 10, 2022
Fixes dotnet#4750. The DELTOOL message of tooltip causes moving of the last tool to the slot of the deleted tool in the tool array (e.g. deleting `Button` from the `[Button, TabControl, TabPage1, TabPage2]` results in `[TabPage1, TabControl, TabPage2]`). This breaks the hit-test logic of the tooltip that checks the tools in the reverse order. Thus the TabControl may be checked earlier than any of TabPages and tooltip will be shown for the TabControl and not for the TabPage.

A possible fix is to reorder the tools in the tools array, but there is no way to access it directly. It is possible to change the array through GETTOOLINFO and SETTOOLINFO messages but this may have undesirable side-effects of breaking caches and other things.

The other way is to remove deletion from the keyboard tooltips logic. But it won't actually help because deletion may be called directly.

The only appropriate solution is to not add a tool for the TabControl itself. It doesn't break anything because the TabControl relays mouse messages to the tooltip by itself (no subclassing is needed) and there is no area where the tool for the TabControl will be shown (hit-testing detects only TabPages, the other things are transparent).Update dependencies from https://github.com/dotnet/runtime build 20220108.4 (dotnet#6486)

[main] Update dependencies from dotnet/runtime
@ghost ghost locked as resolved and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants