Enable nullability in FeatureSupport and IFeatureSupport#6465
Merged
dreddy-work merged 1 commit intodotnet:mainfrom Jan 6, 2022
Merged
Enable nullability in FeatureSupport and IFeatureSupport#6465dreddy-work merged 1 commit intodotnet:mainfrom
dreddy-work merged 1 commit intodotnet:mainfrom
Conversation
RussKie
reviewed
Jan 6, 2022
Comment on lines
+43
to
+44
| IFeatureSupport? featureSupport = (IFeatureSupport?)Activator.CreateInstance(c); | ||
| return featureSupport is not null && featureSupport.IsPresent(featureId, minimumVersion); |
Contributor
There was a problem hiding this comment.
Activator.CreateInstance never returns a null.
https://docs.microsoft.com/en-us/dotnet/api/system.activator.createinstance?view=net-6.0#System_Activator_CreateInstance_System_Type_
Contributor
Author
There was a problem hiding this comment.
Since this was already merged, I did some changes in #6469.
Danil-Andrianov
pushed a commit
to Danil-Andrianov/winforms
that referenced
this pull request
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Microsoft Reviewers: Open in CodeFlow