Skip to content

Filling empty test files for missing ao (part 4)#5877

Merged
RussKie merged 1 commit intodotnet:mainfrom
lisoenot:2-Fill-test-files
Sep 29, 2021
Merged

Filling empty test files for missing ao (part 4)#5877
RussKie merged 1 commit intodotnet:mainfrom
lisoenot:2-Fill-test-files

Conversation

@lisoenot
Copy link
Contributor

@lisoenot lisoenot commented Sep 28, 2021

Proposed changes

This opportunity appears after creating test files for missing ao classes in pr #5731.
Added unit tests for the following classes:

  • ToolStripControlHostAccessibleObject
  • ToolStripDropDownItemAccessibleObject
  • ControlItemAccessibleObject
  • ErrorWindowAccessibleObject

Customer Impact

  • No

Regression?

  • No

Risk

  • Minimal
Microsoft Reviewers: Open in CodeFlow

@lisoenot lisoenot requested a review from a team as a code owner September 28, 2021 14:52
@ghost ghost assigned lisoenot Sep 28, 2021
@lisoenot lisoenot added the waiting-review This item is waiting on review by one or more members of team label Sep 28, 2021
Copy link
Member

@dreddy-work dreddy-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dreddy-work dreddy-work added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Sep 28, 2021
@RussKie RussKie removed waiting-review This item is waiting on review by one or more members of team ready-to-merge PRs that are ready to merge but worth notifying the internal team. labels Sep 29, 2021
@RussKie RussKie merged commit 04c096c into dotnet:main Sep 29, 2021
@ghost ghost added this to the 7.0 alpha1 milestone Sep 29, 2021
@lisoenot lisoenot deleted the 2-Fill-test-files branch September 29, 2021 06:28
@ghost ghost locked as resolved and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants