Skip to content

Created test files for missing ao classes#5731

Merged
RussKie merged 1 commit intodotnet:mainfrom
lisoenot:Create-test-file-for-all-accessible-objects
Sep 13, 2021
Merged

Created test files for missing ao classes#5731
RussKie merged 1 commit intodotnet:mainfrom
lisoenot:Create-test-file-for-all-accessible-objects

Conversation

@lisoenot
Copy link
Contributor

@lisoenot lisoenot commented Sep 9, 2021 •
edited by ghost
Loading

Proposed changes

  • Created test files for missing AO classes
  • Added test for ctor in each test file

Customer Impact

  • No

Regression?

  • No

Risk

  • Minimal
Microsoft Reviewers: Open in CodeFlow

@lisoenot lisoenot requested a review from a team as a code owner September 9, 2021 18:39
@ghost ghost assigned lisoenot Sep 9, 2021
@lisoenot lisoenot added the waiting-review This item is waiting on review by one or more members of team label Sep 9, 2021
@lisoenot lisoenot force-pushed the Create-test-file-for-all-accessible-objects branch from 2576599 to 113ebfa Compare September 9, 2021 18:50
@dreddy-work dreddy-work added the waiting-author-feedback The team requires more information from the author label Sep 9, 2021
@lisoenot lisoenot force-pushed the Create-test-file-for-all-accessible-objects branch from 113ebfa to 27bc96c Compare September 9, 2021 19:53
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Sep 9, 2021
@Tanya-Solyanik Tanya-Solyanik added waiting-author-feedback The team requires more information from the author and removed waiting-review This item is waiting on review by one or more members of team labels Sep 9, 2021
RussKie
RussKie previously approved these changes Sep 10, 2021
View reviewed changes
@RussKie
Copy link
Contributor

RussKie commented Sep 10, 2021

All debug tests failed

GridEntryAccessibleObject must have a valid owner GridEntry
   at System.Windows.Forms.PropertyGridInternal.GridEntry.GridEntryAccessibleObject..ctor(GridEntry owner) in /_/src/System.Windows.Forms/src/System/Windows/Forms/PropertyGridInternal/GridEntry.GridEntryAccessibleObject.cs:line 24
   at System.Windows.Forms.PropertyGridInternal.CategoryGridEntry.CategoryGridEntryAccessibleObject..ctor(CategoryGridEntry owningCategoryGridEntry) in /_/src/System.Windows.Forms/src/System/Windows/Forms/PropertyGridInternal/CategoryGridEntry.CategoryGridEntryAccessibleObject.cs:line 22
   at System.Windows.Forms.Tests.CategoryGridEntryAccessibleObjectTests.CategoryGridEntryAccessibleObject_Ctor_Default() in /_/src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/CategoryGridEntryAccessibleObjectTests.cs:line 15

@lisoenot lisoenot force-pushed the Create-test-file-for-all-accessible-objects branch from 27bc96c to e4b3150 Compare September 10, 2021 11:57
@ghost ghost removed the waiting-author-feedback The team requires more information from the author label Sep 10, 2021
@lisoenot lisoenot force-pushed the Create-test-file-for-all-accessible-objects branch from e4b3150 to 763d30d Compare September 11, 2021 09:53
@lisoenot lisoenot added the waiting-review This item is waiting on review by one or more members of team label Sep 11, 2021
@RussKie RussKie removed the waiting-review This item is waiting on review by one or more members of team label Sep 13, 2021
@RussKie RussKie merged commit 028ddf9 into dotnet:main Sep 13, 2021
@ghost ghost added this to the 7.0 alpha1 milestone Sep 13, 2021
@lisoenot lisoenot deleted the Create-test-file-for-all-accessible-objects branch September 13, 2021 08:08
This was referenced Sep 14, 2021
Merged
Merged
This was referenced Sep 25, 2021
Merged
Merged
This was referenced Oct 1, 2021
Merged
Merged
@lisoenot lisoenot mentioned this pull request Oct 18, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vladimir-krestov vladimir-krestov Awaiting requested review from vladimir-krestov

@SergeySmirnov-Akvelon SergeySmirnov-Akvelon Awaiting requested review from SergeySmirnov-Akvelon

2 more reviewers

@dreddy-work dreddy-work dreddy-work left review comments

@RussKie RussKie RussKie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lisoenot lisoenot

Labels

None yet

Projects

None yet

Milestone

7.0 Preview1

Development

Successfully merging this pull request may close these issues.

4 participants

@lisoenot @RussKie @dreddy-work @Tanya-Solyanik