Always create new small icons for forms #13983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user provided icon matched the size of the small icon we would delete it. Add a regression test.
John-Hart
approved these changes
Oct 22, 2025
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/winforms/actions/runs/18731983854 |
JeremyKuhne
added a commit
that referenced
this pull request
Oct 23, 2025
Backport of #13983 to release/10.0 /cc @JeremyKuhne ## Customer Impact Users setting a Form Icon that matches the current screen small icon size will have their Icon disposed, causing an `ObjectDisposedException` when using the original Icon. There is no easy workaround. ## Testing Manual testing with user scenario. Regression test. ## Risk Low, now always creating a new Icon instance.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13983 +/- ##
===================================================
- Coverage 77.14756% 77.14691% -0.00065%
===================================================
Files 3276 3276
Lines 645117 645125 +8
Branches 47705 47705
===================================================
+ Hits 497692 497694 +2
- Misses 143739 143751 +12
+ Partials 3686 3680 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
kirsan31
reviewed
Oct 23, 2025
Contributor
|
@JeremyKuhne I left a comment in code about this change that's warry me a bit... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user provided icon matched the size of the small icon we would delete it. Add a regression test.
Fixes #13963
Microsoft Reviewers: Open in CodeFlow