Remove prepare-artifacts.proj #4251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3ebe77 to
8667888
Compare
Member
Author
|
cc @mmitche @NikolaMilosavljevic This works locally and in PRs but I need to test with an official build and then see how to get the manifest to compare before and after. |
Member
Author
|
OK, the manifest diff doesn't look right: https://www.diffchecker.com/pIvJFmna/ |
8acf04e to
b5f7183
Compare
b5f7183 to
81d3f20
Compare
Member
Author
|
Fixed the difference and the BlobArtifacts and PackageArtifacts folders are now identical. Waiting for the Arcade change to flow in. |
jkoritzinsky
approved these changes
Mar 18, 2024
This was referenced Mar 18, 2024
dkurepa
added a commit
to dkurepa/windowsdesktop
that referenced
this pull request
Mar 25, 2024
This reverts commit bccc080.
mmitche
pushed a commit
that referenced
this pull request
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... use Arcade's common publishing infrastructure
This now produces all the artifacts in the VMR build as well:
Removes the different publishing infrastructure between VMR build and repo-build.
Requires dotnet/arcade#14602 (to not break the official build)
Contributes to dotnet/source-build#4101