Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Darwin Build_Release), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@nguerrera guessing we don't want this for the upcoming 3.1.2xx release?

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_6_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_OpenSUSE_42_3_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Darwin Build_Release), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@wtgodbe I think roslyn should be ok. We left all the tools flowing intentionally. The goal is to match the tools going to VS.

It's the runtimes we want to keep out.

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_6_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_OpenSUSE_42_3_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Darwin Build_Release), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

##[error]src\redist\redist.csproj(0,0): error NU1603: redist depends on Microsoft.Net.Compilers.Toolset (>= 3.5.0-beta3-20104-02) but Microsoft.Net.Compilers.Toolset 3.5.0-beta3-20104-02 was not found. An approximate best match of Microsoft.Net.Compilers.Toolset 9.9.0-beta3-19304-14 was resolved.

Looks like we're missing a feed

@agocke

Seems unexpected that going from one build to another would require a different feed.

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_6_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_OpenSUSE_42_3_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Darwin Build_Release), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

Think it's because dotnet/roslyn#41373 reverted an Arcade update, causing the corresponding build to not even try to publish to the 3.1.2xx feed: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=3441625. This happened ~1 month ago, we pushed that Arcade update in order to resolve this issue the first time around. @agocke why did you revert it? Should we be ingesting a different branch of Roslyn (rather than release/dev16.5-preview3-vs-deps)?

cc @jaredpar

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_6_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_OpenSUSE_42_3_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Darwin Build_Release), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

What does master have to do with 3.1.2xx? that's a release/ branch? We reverted the arcade update because it broke the master signed build.

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_6_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_OpenSUSE_42_3_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Darwin Build_Release), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@agocke the commit got merged into the release/dev16.5-preview3-vs-deps branch as well: https://github.com/dotnet/roslyn/commits/release/dev16.5-preview3-vs-deps

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_6_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_OpenSUSE_42_3_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Darwin Build_Release), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

I changed the feeds this morning, could it be that there was a race, st. the feed subscription wasn't available before the build queued? But in that case, why does maestro think this is a valid build?

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_6_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_OpenSUSE_42_3_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Darwin Build_Release), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@agocke did you mess with the Roslyn branches? This PR is ingesting a change into dev16.5-preview3-vs-deps, which no longer exists, but is still mapped to the 3.1.2xx channel. Your PR went into release/dev16.5, which isn't mapped to any channel: dotnet/roslyn#41417. We still aren't unblocked here.

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_6_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_OpenSUSE_42_3_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Darwin Build_Release), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

Yes, the branch creation was wrong. I'll be cleaning it up this morning.

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_6_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_OpenSUSE_42_3_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Darwin Build_Release), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

Will be unblocked by dotnet/roslyn#41436

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_6_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_OpenSUSE_42_3_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Darwin Build_Release), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

Will be unblocked after this build https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=3447335

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_6_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_OpenSUSE_42_3_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Darwin Build_Release), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@wtgodbe
https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=3447335 failed

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86), .NET Core Toolset CI (build Darwin Build_Release)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

�[39;49m�[31m/opt/code/src/redist/targets/GenerateLayout.targets(18,5): error : Something moved around in Roslyn package, adjust code here accordingly. TFM change? [/opt/code/src/redist/redist.csproj]

@wli3 @dsplaisted could you take a look?

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_6_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_OpenSUSE_42_3_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Darwin Build_Release)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

This was expected. I’ll make the fix.

Actually if someone can beat me to it that’s fine. There’s a netcoreapp2.1 around the line of the error. Change it to 3.1. FYI @jaredpar

Actually if someone can beat me to it that’s fine. There’s a netcoreapp2.1 around the line of the error. Change it to 3.1.

Done

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

• ❌ Standard Merge Policies Unsuccessful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

Wait, huh, the PR that I thought was going to cause this is still open: dotnet/roslyn#41370 ?

@jaredpar

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

• ✔️ Standard Merge Policies Succeeded - Successful checks: .NET Core Toolset CI, .NET Core Toolset CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core Toolset CI (build Linux Build_LinuxPortable_Release_x64), .NET Core Toolset CI (build Linux Build_Linux_musl_Debug_x64), .NET Core Toolset CI (build Linux Build_Rhel_6_Debug_x64), .NET Core Toolset CI (build Linux Build_Debian_Jessie_Debug_x64), .NET Core Toolset CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core Toolset CI (build Linux Build_OpenSUSE_42_3_Debug_x64), .NET Core Toolset CI (build Linux Build_Fedora_27_Debug_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core Toolset CI (build Darwin Build_Release), .NET Core Toolset CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core Toolset CI (build Windows_NT Build_Release_x64), .NET Core Toolset CI (build Linux Build_Ubuntu_14_04_Release_x64), .NET Core Toolset CI (build Windows_NT Build_Debug_x86)
• ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

All good the actual change to the app tfm came earlier. Confirmed offline with Jared. 😃