Fix tasks not loading on .NET Framework#8952
Merged
ViktorHofer merged 3 commits intomainfrom Apr 17, 2025
Merged
Conversation
... due to inconsistent TFMs. See #8864 (comment) for more details
MiYanni
approved these changes
Apr 16, 2025
Member
MiYanni
left a comment
There was a problem hiding this comment.
I like the change overall but looks like some of the code is now missing features from certain .NET versions (according to the build failures).
Member
Author
|
Probably needs the ValueTuple package. Will fix tomorrow. |
Member
Author
|
/backport to release/9.0.1xx |
Contributor
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/templating/actions/runs/14510819787 |
Contributor
|
@ViktorHofer backporting to "release/9.0.1xx" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix tasks not loading on .NET Framework
Using index info to reconstruct a base tree...
M tools/Microsoft.TemplateEngine.Authoring.TemplateVerifier/Microsoft.TemplateEngine.Authoring.TemplateVerifier.csproj
M tools/Microsoft.TemplateSearch.TemplateDiscovery/Microsoft.TemplateSearch.TemplateDiscovery.csproj
Falling back to patching base and 3-way merge...
Auto-merging tools/Microsoft.TemplateSearch.TemplateDiscovery/Microsoft.TemplateSearch.TemplateDiscovery.csproj
CONFLICT (content): Merge conflict in tools/Microsoft.TemplateSearch.TemplateDiscovery/Microsoft.TemplateSearch.TemplateDiscovery.csproj
Auto-merging tools/Microsoft.TemplateEngine.Authoring.TemplateVerifier/Microsoft.TemplateEngine.Authoring.TemplateVerifier.csproj
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Fix tasks not loading on .NET Framework
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
ViktorHofer
added a commit
that referenced
this pull request
Apr 17, 2025
* Fix tasks not loading on .NET Framework ... due to inconsistent TFMs. See #8864 (comment) for more details * Fix TFMs and set NetFrameworkMinimum to net472 * Build NetCurrent in source-only builds
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... due to inconsistent TFMs. See #8864 (comment) for more details
Problem
Fixes loading templating tasks on .NET Framework due to inconsistent TFMs.
Solution
For non samples, non test projects and non templates, change the following TFMs:
Checks: