Skip to content

Look for precise match#8790

Merged
nohwnd merged 2 commits intomainfrom
look-for-precise-match
Mar 6, 2025
Merged

Look for precise match#8790
nohwnd merged 2 commits intomainfrom
look-for-precise-match

Conversation

@nohwnd
Copy link
Copy Markdown
Member

@nohwnd nohwnd commented Mar 5, 2025

Problem

Fix #8789

Solution

We keep looking for precise match even if there are already multiple partial matches.

Checks:

  • Added unit tests

@nohwnd nohwnd requested a review from a team as a code owner March 5, 2025 12:49
@nohwnd nohwnd enabled auto-merge March 6, 2025 14:39
@nohwnd nohwnd merged commit 1b067f9 into main Mar 6, 2025
10 checks passed
@marcpopMSFT
Copy link
Copy Markdown
Member

If there is an exact match, use it. If there's one partial match, use it. Only error if multiple partial matches and no exact match. Fix looks right to me.

@marcpopMSFT
Copy link
Copy Markdown
Member

/backport to release/9.0.3xx

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2025

Started backporting to release/9.0.3xx: https://github.com/dotnet/templating/actions/runs/13704246019

@marcpopMSFT marcpopMSFT deleted the look-for-precise-match branch August 1, 2025 18:12
mmitche pushed a commit to dotnet/sdk that referenced this pull request Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple partial matches bug.

2 participants