add support for renamed projects in the add reference post action#4922
Merged
vlada-shubina merged 7 commits intodotnet:mainfrom Jul 12, 2022
Merged
Conversation
|
|
JanKrivanek
requested changes
Jul 8, 2022
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
There are couple of minor improvements needed.
Please add an explicit unit or integration test as well (it would catch issues with the current fix)
src/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddReferencePostActionProcessor.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddReferencePostActionProcessor.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddReferencePostActionProcessor.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddReferencePostActionProcessor.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I added the unit test and refined the change with your improvements. For the unit test, I needed a new Mock class; should I move this into the |
vlada-shubina
approved these changes
Jul 11, 2022
Member
vlada-shubina
left a comment
There was a problem hiding this comment.
Thank you. We also need to update docs for this change.
src/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddReferencePostActionProcessor.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TemplateEngine.Cli.UnitTests/AddReferencePostActionTests.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
I also took the liberty to add an example use for this post action in the documentation. |
baronfel
approved these changes
Jul 11, 2022
Member
baronfel
left a comment
There was a problem hiding this comment.
Very cool - thanks for this contribution, and double thanks for the docs example!
JanKrivanek
approved these changes
Jul 12, 2022
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks good!
Thank you for the changes!
vlada-shubina
pushed a commit
to vlada-shubina/templating
that referenced
this pull request
Aug 23, 2022
…tnet#4922) * added support for renamed projects in the add reference post action * added unit test for fixed case * refined fix to be clearer and more concise * changed fix to use GetTargetForSource * changed changekind to create in unit test * add unit case for case where referenced project was not renamed * add documentation in post action registry Co-authored-by: Robin Knoll <Robin.Knoll@world-direct.at> # Conflicts: # src/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddReferencePostActionProcessor.cs
vlada-shubina
pushed a commit
to vlada-shubina/templating
that referenced
this pull request
Aug 23, 2022
…tnet#4922) * added support for renamed projects in the add reference post action * added unit test for fixed case * refined fix to be clearer and more concise * changed fix to use GetTargetForSource * changed changekind to create in unit test * add unit case for case where referenced project was not renamed * add documentation in post action registry Co-authored-by: Robin Knoll <Robin.Knoll@world-direct.at> # Conflicts: # src/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddReferencePostActionProcessor.cs
vlada-shubina
pushed a commit
to vlada-shubina/templating
that referenced
this pull request
Aug 23, 2022
…tnet#4922) * added support for renamed projects in the add reference post action * added unit test for fixed case * refined fix to be clearer and more concise * changed fix to use GetTargetForSource * changed changekind to create in unit test * add unit case for case where referenced project was not renamed * add documentation in post action registry Co-authored-by: Robin Knoll <Robin.Knoll@world-direct.at> # Conflicts: # src/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddReferencePostActionProcessor.cs
vlada-shubina
pushed a commit
to vlada-shubina/templating
that referenced
this pull request
Aug 23, 2022
…tnet#4922) * added support for renamed projects in the add reference post action * added unit test for fixed case * refined fix to be clearer and more concise * changed fix to use GetTargetForSource * changed changekind to create in unit test * add unit case for case where referenced project was not renamed * add documentation in post action registry Co-authored-by: Robin Knoll <Robin.Knoll@world-direct.at> # Conflicts: # src/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddReferencePostActionProcessor.cs
vlada-shubina
pushed a commit
to vlada-shubina/templating
that referenced
this pull request
Aug 23, 2022
…tnet#4922) * added support for renamed projects in the add reference post action * added unit test for fixed case * refined fix to be clearer and more concise * changed fix to use GetTargetForSource * changed changekind to create in unit test * add unit case for case where referenced project was not renamed * add documentation in post action registry Co-authored-by: Robin Knoll <Robin.Knoll@world-direct.at> # Conflicts: # src/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddReferencePostActionProcessor.cs
vlada-shubina
pushed a commit
that referenced
this pull request
Sep 7, 2022
) * added support for renamed projects in the add reference post action * added unit test for fixed case * refined fix to be clearer and more concise * changed fix to use GetTargetForSource * changed changekind to create in unit test * add unit case for case where referenced project was not renamed * add documentation in post action registry Co-authored-by: Robin Knoll <Robin.Knoll@world-direct.at> # Conflicts: # src/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddReferencePostActionProcessor.cs
mmitche
pushed a commit
to dotnet/sdk
that referenced
this pull request
Apr 2, 2026
…tnet/templating#4922) * added support for renamed projects in the add reference post action * added unit test for fixed case * refined fix to be clearer and more concise * changed fix to use GetTargetForSource * changed changekind to create in unit test * add unit case for case where referenced project was not renamed * add documentation in post action registry Co-authored-by: Robin Knoll <Robin.Knoll@world-direct.at> Commit migrated from dotnet/templating@2876985
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The post action AddReference (B17581D1-C5C9-4489-8F0A-004BE667B814) is unable to add project references if the referenced project has been renamed during template instantiation. This is because the post action does not check for renames, but only looks for the old project name.
Solution
The post action should replace the name of the referenced project in case it has been renamed. This is a similar functionality as in the targetFiles argument, where the name replacement works fine.