Fix MockTemplateInfo for System.Text.Json serialization#10066
Merged
lewing merged 1 commit intodotnet:mainfrom Mar 27, 2026
Merged
Fix MockTemplateInfo for System.Text.Json serialization#10066lewing merged 1 commit intodotnet:mainfrom
lewing merged 1 commit intodotnet:mainfrom
Conversation
After the Newtonsoft.Json → System.Text.Json migration (dotnet#9956), MockTemplateInfo's explicit ITemplateInfo.Tags and CacheParameters implementations throw NotImplementedException. Newtonsoft never hit these during serialization, but System.Text.Json walks all interface properties, causing TemplateDiscoveryMetadata.ToJObject() to crash in the SDK's CacheSearchCoordinatorTests. Return empty dictionaries instead of throwing. Both properties are [Obsolete] and the mock's real data lives in TagsCollection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
47a1f90 to
2eeb888
Compare
akoeplinger
approved these changes
Mar 27, 2026
Member
|
/backport to release/11.0.1xx-preview3 |
Contributor
|
Started backporting to |
Contributor
|
@dsplaisted an error occurred while backporting to |
dsplaisted
added a commit
to dsplaisted/dotnet
that referenced
this pull request
Apr 9, 2026
…J serialization Backport of dotnet/templating#10066 to release/11.0.1xx-preview3. After the Newtonsoft.Json to System.Text.Json migration, MockTemplateInfo's explicit ITemplateInfo.Tags and ITemplateInfo.CacheParameters implementations throw NotImplementedException. System.Text.Json walks all interface properties during serialization, causing TemplateSearchCoordinator tests to crash. Return null! instead of throwing, matching what dotnet/templating main has. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the Newtonsoft.Json → System.Text.Json migration (#9956),
MockTemplateInfo's explicitITemplateInfo.TagsandITemplateInfo.CacheParametersimplementations throwNotImplementedException. Newtonsoft never visited these during serialization, but System.Text.Json walks all interface properties when serializing, causingTemplateDiscoveryMetadata.ToJObject()to crash:This breaks all
CacheSearchCoordinatorTestsin the SDK CI (sdk#53613).Fix
Return empty dictionaries instead of throwing. Both properties are
[Obsolete]— the mock's real tag data lives in theTagsCollectionproperty.