Conversation
This moves the project to use netstandard2.0 as the base target framework for projects. There is no value in maintaining netstandard1.1 and net20 anymore.
| try | ||
| { | ||
| #if NET20 | ||
| return Environment.GetEnvironmentVariable(name); |
There was a problem hiding this comment.
Ah okay. Will fix that.
|
Let's also set version here: https://github.com/dotnet/symreader/blob/main/eng/Versions.props#L6 tp 2.0.0 since this is a breaking change. |
|
|
||
| #else | ||
|
|
||
| [assembly: System.Security.AllowPartiallyTrustedCallers] |
There was a problem hiding this comment.
@tmat want to make sure u see that I deleted this. It seems to serve no purpose and just cause issues. Want to make sure I'm not missing a reason for it being there.
There was a problem hiding this comment.
I don't recall why we had it. Seems unnecessary for netstandard2.0.
|
@tmat version updated |
|
Sorry for commenting on an old PR but any idea why this change never shipped to customers? NuGet's latest version is still 1.4.0. |
|
@tmat will need to answer as I'm unfamiliar with how NuPkg are produced from this repo |
|
@tmat would you know the answer to my above question? |
|
@jaredpar This repo changes very rarely. We don't produce release versions regularly. |
|
Can we please prioritize releasing a new version with the netstandard2.0 change? The existing package version brings in NETStandard.Library/1.6.1 which itself transitively brings in the entire .NET Standard 1.6 dependency graph (which is huge). That graph might contains either deprecated or vulnerable packages which we haven't touched for years. I noticed this as I looked into a package that depends on Microsoft.DiaSymReader and the reference caused Component Governance warnings. |
|
Created an issue for this: #282 |
This moves the project to use netstandard2.0 as the base target
framework for projects. There is no value in maintaining netstandard1.1
and net20 anymore.