update System.CommandLine #1356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
commented
Jan 30, 2025
| string? password = parseResult.GetValue(passwordArg); | ||
| bool offline = parseResult.GetValue(offlineArg); | ||
|
|
||
| return TestAsync(path, authMethod, authEncoding, user, password, offline, parseResult, cancellationToken); |
Member
Author
There was a problem hiding this comment.
CommandHandler.Create was part of NamingConventionBinder which would use reflection just to achieve what I've written here
adamsitnik
commented
Jan 30, 2025
| var authenticationHeader = (authMethod != null) ? GetAuthenticationHeader(authMethod, authEncoding ?? Encoding.ASCII, user!, password!) : null; | ||
|
|
||
| var cancellationSource = new CancellationTokenSource(); | ||
| Console.CancelKeyPress += (sender, e) => |
Member
Author
There was a problem hiding this comment.
this is not required, S.CL will do this on it's own, we just need to pass the CancellationToken
ViktorHofer
reviewed
Jan 30, 2025
eng/Version.Details.xml
Outdated
| <Sha>060374e56c1b2e741b6525ca8417006efb54fbd7</Sha> | ||
| </Dependency> | ||
| <!-- Intermediate is necessary for source build. --> | ||
| <Dependency Name="Microsoft.SourceBuild.Intermediate.command-line-api" Version="0.1.430701"> |
Member
There was a problem hiding this comment.
The source-build error in CI will go away when you update this version to the corresponding one that matches the new version.
ViktorHofer
approved these changes
Jan 31, 2025
adamsitnik
added a commit
to adamsitnik/sourcelink
that referenced
this pull request
Feb 6, 2025
This reverts commit 3c34adc.
adamsitnik
added a commit
to adamsitnik/sourcelink
that referenced
this pull request
Feb 6, 2025
This reverts commit 3c34adc.
adamsitnik
added a commit
to adamsitnik/sourcelink
that referenced
this pull request
Feb 6, 2025
…al of two dependencies (dotnet#1363) This reverts commit 3ce7edb.
ViktorHofer
pushed a commit
that referenced
this pull request
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of: