Conversation
|
@jjonescz, can you confirm the consumption of this dependency is something that will be completed for .NET 10? TIA |
|
Yes, once this is available, I will replace interactivity implemented manually in the sdk with the library. That's only for a couple for interactive prompts in |
|
@jjonescz - this appears to have caused a build failing in the flow to the VMR. Can you take a look? TIA. |
|
@MichaelSimons other jobs also fail with this: |
|
@jjonescz, Was the work completed to take a dependency on this package? I ask because we have some reporting that is flagging the |
|
Not yet. Turned out we need some more process before ingesting the package in product (like security review) and so it might be postponed to .net 11 since it's not a huge priority. |
|
Sorry if it's causing problems. Feel free to revert this PR (or I can do that, lmk) if that would help. Thanks. |
Context: dotnet#1287 * Update spectre-console submodule to 0.52.0 * Add patch file to delete problematic binaries: dotnet#1287 (comment) Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
Context: dotnet#1287 * Update spectre-console submodule to 0.52.0 * Add patch file to delete problematic binaries: dotnet#1287 (comment) Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
Context: dotnet#1287 * Update spectre-console submodule to 0.52.0 * Add patch file to delete problematic binaries: dotnet#1287 (comment) Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
Context: dotnet/source-build-reference-packages#1447 Context: dotnet/source-build-reference-packages#1287 (comment) The docs folder contains binary files, that are not needed for building from source.
Context: dotnet#1287 * Update spectre-console submodule to 0.52.0 * Add patch file to delete problematic binaries: dotnet#1287 (comment) Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>
* Add Spectre.Console 0.52.0 (#1287) Context: #1287 * Update spectre-console submodule to 0.52.0 * Add patch file to delete problematic binaries: #1287 (comment) Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> * Remove binary patch again * Pin darc version * Add DelaySign and PublicSign to build arguments --------- Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> Co-authored-by: Premek Vysoky <premek.vysoky@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
* Add Spectre.Console 0.52.0 (dotnet#1287) Context: dotnet#1287 * Update spectre-console submodule to 0.52.0 * Add patch file to delete problematic binaries: dotnet#1287 (comment) Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> * Remove binary patch again * Pin darc version * Add DelaySign and PublicSign to build arguments --------- Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> Co-authored-by: Premek Vysoky <premek.vysoky@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
* Add Spectre.Console 0.52.0 (#1447) * Add Spectre.Console 0.52.0 (#1287) Context: #1287 * Update spectre-console submodule to 0.52.0 * Add patch file to delete problematic binaries: #1287 (comment) Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> * Remove binary patch again * Pin darc version * Add DelaySign and PublicSign to build arguments --------- Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> Co-authored-by: Premek Vysoky <premek.vysoky@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> * Update spectre.console (#1482) * Upgrade Spectre.Console to 0.54.0 * Make build work Add wcwsith.sources version 4.0.1 Update spectre-console's patch * Remove wcwidth.sources which was upgraded to 4.0.1 --------- Co-authored-by: Michael Simons <msimons@microsoft.com> --------- Co-authored-by: Jonathan Peppers <jonathan.peppers@gmail.com> Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> Co-authored-by: Premek Vysoky <premek.vysoky@microsoft.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Michael Simons <msimons@microsoft.com>
Based on reverting dotnet/source-build-externals#467.