Remove netstandard1.x packages and support infrastructure#1179
Merged
MichaelSimons merged 2 commits intomainfrom Feb 28, 2025
Merged
Remove netstandard1.x packages and support infrastructure#1179MichaelSimons merged 2 commits intomainfrom
MichaelSimons merged 2 commits intomainfrom
Conversation
fca9466 to
2ad2f39
Compare
cca61ea to
f8d00be
Compare
Member
Author
|
NO merge until we validated this with a VMR source-only build: dotnet/sdk#47191 |
ViktorHofer
added a commit
to dotnet/sdk
that referenced
this pull request
Feb 28, 2025
Try changes made in dotnet/source-build-assets#1179
This was referenced Feb 28, 2025
Member
Author
|
OK after talking to @MichaelSimons offline, he let me know that this PR removes a few packages that are still used and aren't reported correctly by the tooling: dotnet/source-build#4924 He also suggested to wait until #1181 is merged to make this PR focused on just the netstandard1.x removal. I will drop commit 1 and rebase on top of main when the other PR is merged which will also make commit 3 and 4 go away. |
47165f0 to
16af257
Compare
Member
|
I queued a full VMR test build at dotnet/sdk#47172 |
MichaelSimons
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#4482
Commit 1
Remove netstandard1.x only packages that weren't removed in f0ea129. My guess is that they weren't reported because
Microsoft.NetCore.Targets/1.1.0depended on them (which also gets removed now as part of this commit). So there was a cycle which hindered the tooling to flag all those packages.I forgot to mention that this PR also removes a few netcoreapp1.x leftover packages which have the same matching
4.3.0version as the netstandard1.x packages.Commit 2
Filter out netstandard1.x TFMs when generating new packages with the PackageSourceGenerator tooling.