[release/6.0] Update application-insights to 2.19.0#2996
Merged
MichaelSimons merged 5 commits intodotnet:release/6.0from Aug 19, 2022
Merged
[release/6.0] Update application-insights to 2.19.0#2996MichaelSimons merged 5 commits intodotnet:release/6.0from
MichaelSimons merged 5 commits intodotnet:release/6.0from
Conversation
MichaelSimons
approved these changes
Aug 18, 2022
Member
|
@lbussell - Are these changes also needed? dotnet/source-build-externals#33 |
Member
Author
Trying to figure that out now - will add them if needed. |
Member
|
IIRC this is only an issue in the tarball where it removes the online feeds from the known nuget.configs. |
Member
|
...The result is the potential for prebuilts because NuGet non-determinism. |
eng/SourceBuildPrebuiltBaseline.xml
Outdated
| <UsageData> | ||
| <IgnorePatterns> | ||
| <UsagePattern IdentityGlob="*/*" /> | ||
| <UsagePattern IdentityGlob="Microsoft.SourceBuild.Intermediate.*/*" /> |
Member
There was a problem hiding this comment.
I don't think we should be enabling prebuilt detection with these changes. There are likely other changes needed to get the repo level prebuilts clean. We don't want to block this PR on them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #2994.
Also see