Skip to content

Update application insights version#22974

Merged
marcpopMSFT merged 3 commits intomainfrom
marcpopMSFT-updateappinsights
Feb 3, 2022
Merged

Update application insights version#22974
marcpopMSFT merged 3 commits intomainfrom
marcpopMSFT-updateappinsights

Conversation

@marcpopMSFT
Copy link
Copy Markdown
Member

No description provided.

@ghost ghost added the Area-Infrastructure label Dec 8, 2021
@marcpopMSFT marcpopMSFT force-pushed the marcpopMSFT-updateappinsights branch from 4c40195 to e56a02c Compare December 9, 2021 00:57
@marcpopMSFT
Copy link
Copy Markdown
Member Author

See microsoft/ApplicationInsights-dotnet#1152 for more details on this change. Unfortunately, I'm missing context on telemetry to be sure the fix is correct.

Copy link
Copy Markdown
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per this comment

Keep one TelemetryConfiguration per app lifetime (a few is also fine), but you may create as many clients as you want.
Do not forget to dispose TelemetryConfiguration when gracefully shutting down the application.

It looks like we're not doing that here, and probably we should be.

@marcpopMSFT
Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@marcpopMSFT marcpopMSFT merged commit e4aa411 into main Feb 3, 2022
@marcpopMSFT marcpopMSFT deleted the marcpopMSFT-updateappinsights branch February 4, 2022 17:52
marcpopMSFT added a commit that referenced this pull request Jul 11, 2022
marcpopMSFT added a commit that referenced this pull request Aug 2, 2022
Merge pull request #22974 from dotnet/marcpopMSFT-updateappinsights
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants