Improve detection of Dynamics Business Central .app files#846
Conversation
c492166 to
9bb1090
Compare
9bb1090 to
ccc15cd
Compare
|
Awesome change. Seems like we can closely move extensions to the dynamic file type as we run into similar bugs. I think the magic byte detection will go a long way. Is there an escape hatch for the user, before a bug fix like this, so say "myjson.app" should not be signed? |
|
Thanks. Yes, there was/is an escape hatch: using glob patterns. However, that approach is not well documented, so I don't see users figuring it out quickly/easily. |
It might be worth giving a minimal, thrown together in that issue description prior to full documentation. If it only takes a minute. Just a thought! |
Resolve #824.
#652 added support for signing Dynamics Business Central
.appfiles, but the.appfile extension is not exclusive to Dynamics Business Central apps. In this bug, Sign CLI fails to sign a JSON file with an.appfile extension.This change updates Sign CLI to be smarter about detecting Dynamics Business Central
.appfiles. These files begin with a 4-byte header4e 41 56 58(NAVX), so we should only try signing if an.appfile starts with this header.CC @aholstrup1