Support signing Dynamics Business Central App files#652
Merged
dtivel merged 5 commits intodotnet:mainfrom Feb 23, 2024
Merged
Conversation
dtivel
requested changes
Feb 7, 2024
dtivel
reviewed
Feb 7, 2024
Co-authored-by: Damon Tivel <dtivel@microsoft.com>
dtivel
reviewed
Feb 8, 2024
dtivel
approved these changes
Feb 23, 2024
| <Project> | ||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Windows.SDK.BuildTools" IncludeAssets="build" PrivateAssets="all" /> | ||
| <PackageReference Include="Microsoft.Dynamics.BusinessCentral.Sip.Main" GeneratePathProperty="true" ExcludeAssets="All" /> |
Contributor
There was a problem hiding this comment.
Does this need a PrivateAssets="all"?
This was referenced Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support signing Dynamics Business Central App (.app) files
Support for signing Dynamics Business Central files is done by:
Fixes #173