Allow 'code' commands to accept multiple file arguments#816
Merged
dtivel merged 1 commit intodotnet:mainfrom Apr 22, 2025
Merged
Allow 'code' commands to accept multiple file arguments#816dtivel merged 1 commit intodotnet:mainfrom
dtivel merged 1 commit intodotnet:mainfrom
Conversation
Collaborator
|
@bgrainger, this change looks good. Can you please rebase on latest and update? |
…#815 The command documentation specifies that these commands take a "file(s)" parameter. They currently accept only a single argument, although it can be a glob to specify multiple files. This changes them to accept multiple filenames as separate arguments, similar to the existing behavior of signtool and azuresigntool.
f20b5be to
3226e7c
Compare
Contributor
Author
|
Rebased. |
dtivel
approved these changes
Apr 22, 2025
jeffkl
approved these changes
Apr 22, 2025
Collaborator
|
@bgrainger, this should be available in 0.9.1-beta.25224.2. |
bgrainger
added a commit
to Faithlife/FaithlifeBuild
that referenced
this pull request
Jan 12, 2026
The upstream repo has fixed the two issues we created a fork for: - Accept multiple file names: dotnet/sign#816 - Use just Azure CLI credential: dotnet/sign#891
bgrainger
added a commit
to Faithlife/FaithlifeBuild
that referenced
this pull request
Jan 12, 2026
The upstream repo has fixed the two issues we created a fork for: - Accept multiple file names: dotnet/sign#816 - Use just Azure CLI credential: dotnet/sign#891
This was referenced Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #815
The command documentation specifies that these commands take a "file(s)" parameter. They currently accept only a single argument, although it can be a glob to specify multiple files. This changes them to accept multiple filenames as separate arguments, similar to the existing behavior of signtool and azuresigntool.