Conversation
dtivel
reviewed
Dec 11, 2024
src/Sign.SignatureProviders.TrustedSigning/TrustedSigningService.cs
Outdated
Show resolved
Hide resolved
8463ad2 to
67fb84e
Compare
dtivel
reviewed
Jan 6, 2025
dtivel
reviewed
Jan 6, 2025
dtivel
reviewed
Jan 6, 2025
dtivel
reviewed
Jan 6, 2025
dtivel
reviewed
Jan 6, 2025
dtivel
reviewed
Jan 6, 2025
test/Sign.SignatureProviders.TrustedSigning.Test/TrustedSigningServiceProviderTests.cs
Outdated
Show resolved
Hide resolved
dtivel
reviewed
Jan 6, 2025
test/Sign.SignatureProviders.TrustedSigning.Test/TrustedSigningServiceTests.cs
Outdated
Show resolved
Hide resolved
dtivel
reviewed
Jan 6, 2025
test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProviderTests.cs
Outdated
Show resolved
Hide resolved
dtivel
reviewed
Jan 6, 2025
test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProviderTests.cs
Outdated
Show resolved
Hide resolved
dtivel
reviewed
Jan 6, 2025
test/Sign.SignatureProviders.KeyVault.Test/KeyVaultServiceProviderTests.cs
Outdated
Show resolved
Hide resolved
dtivel
reviewed
Jan 6, 2025
dtivel
reviewed
Jan 6, 2025
Collaborator
dtivel
left a comment
There was a problem hiding this comment.
Minor feedback. Looks good!
- Introduced a private field `servicesToAdd` in `ServiceProviderFactory` to store additional services. - Added `AddServices` method to `ServiceProviderFactory` to add services via an `Action<IServiceCollection>` parameter. - Updated `Create` method to include `servicesToAdd` if not null. - Added `ServiceProviderFactoryTests` to verify new functionality. - Tests include null check, service addition, and service provider creation. - Defined `ITestService`, `TestService`, `ITestService2`, and `TestService2` for testing purposes.
Introduce Microsoft.Extensions.Azure package and refactor TrustedSigningService to use dependency injection for CertificateProfileClient. Update TrustedSigningServiceProvider to rely on service provider for instances. Add localized string resources for "Certificate Details" in multiple languages. Update tests to reflect changes and remove obsolete tests. Log detailed certificate information in TrustedSigningService.
…existing ones to match.
…ly disposed of after use.
- Updated `AzureKeyVaultCommand.cs` to construct and validate URIs for certificates and keys using Azure SDK, and configured Azure clients and services with dependency injection so logging forwards through. - Added `InvalidKeyVaultUrl` localized string in `AzureKeyVaultResources.Designer.cs` and updated `AzureKeyVaultResources.resx`. - Refactored `KeyVaultService.cs` to use `CertificateClient` and `CryptographyClient` for simplified service operations. - Simplified `KeyVaultServiceProvider.cs` by using dependency injection for `KeyVaultService` retrieval. - Removed `PrivateAssets` attribute from `Azure.Security.KeyVault.Certificates` and `Azure.Security.KeyVault.Keys` in `Sign.SignatureProviders.KeyVault.csproj` for runtime availability.
Also avoids unused parameter error
Co-authored-by: Damon Tivel <dtivel@microsoft.com>
…e when signing fails
dtivel
previously approved these changes
Feb 11, 2025
Collaborator
|
@dotnet/sign-maintainers, can I get a re-review? I applied my feedback on Claire's PR. Since I'm now a contributor, I need an outside reviewer. |
dtivel
previously approved these changes
Feb 11, 2025
erdembayar
reviewed
Feb 13, 2025
erdembayar
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored to use Azure services via DI as that also configures it to work with ILogger.