Enable and fix WASM tests#52960
Merged
tmat merged 4 commits intodotnet:release/10.0.3xxfrom Feb 19, 2026
Merged
Conversation
2b03ecb to
5f99f1b
Compare
tmat
commented
Feb 11, 2026
| { | ||
| stream = File.Open(path, FileMode.Open, FileAccess.Read, FileShare.ReadWrite | FileShare.Delete); | ||
| } | ||
| catch (FileNotFoundException) |
Member
Author
There was a problem hiding this comment.
Need to follow up on why the manifest is sometimes not be produced by the build... #52994
dc55cf4 to
250e130
Compare
4c3ebfd to
9e2a62f
Compare
Member
Author
|
@maraf ptal |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes WASM hot reload test failures by correcting the asset layout for Microsoft.DotNet.HotReload.WebAssembly.Browser. The tests were failing because the hot reload agent DLL and JavaScript module were not being copied to the correct directory structure in the SDK package. The fix centralizes target framework versioning and updates the ProjectReference configuration to properly include the hot reload agent outputs.
Changes:
- Fixed WASM hot reload asset paths (removed incorrect
wwwroot\prefix from package layout) - Introduced centralized target framework version management via
TargetFrameworks.props - Re-enabled previously skipped WASM hot reload tests across Windows and non-Windows platforms
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/WasmSdk/Sdk/TargetFrameworks.props |
New file defining centralized WASM agent target framework version (net10.0) |
src/WasmSdk/Tasks/Microsoft.NET.Sdk.WebAssembly.Tasks.csproj |
Updated ProjectReference to use OutputItemType/PackagePath/Targets for proper asset inclusion; removed manual AdditionalContent include; added TargetFrameworks.props import; updated CopyAdditionalFilesToLayout condition |
src/WasmSdk/Sdk/Sdk.targets |
Fixed source path for hot reload JS module (removed wwwroot\ prefix); uses WasmAgentTargetFrameworkV10 property; imports TargetFrameworks.props |
src/BuiltInTools/HotReloadAgent.WebAssembly.Browser/Microsoft.DotNet.HotReload.WebAssembly.Browser.csproj |
Uses centralized WasmAgentTargetFrameworkV10 property instead of hardcoded net10.0 |
test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs |
Removed Windows-only restrictions and Skip attributes from WASM tests; added identifier parameter for test isolation; updated test assertions; fixed typo ("it's" → "its"); updated issue reference from #49928 to #53058 |
test/dotnet-watch.Tests/Browser/BrowserTests.cs |
Removed Windows-only restriction from BrowserDiagnostics test |
src/BuiltInTools/Watch/Build/EvaluationResult.cs |
Fixed file extension comparison to use case-appropriate string comparison |
src/BuiltInTools/HotReloadClient/Web/StaticWebAssetsManifest.cs |
Added explicit FileNotFoundException handling to avoid error logging for expected missing files |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/ba-g Linux machine is crashing with no logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Microsoft.DotNet.HotReload.WebAssembly.Browser asset layout. The test were failing to build WASM projects because
Microsoft.DotNet.HotReload.WebAssembly.Browser.lib.module.jsandMicrosoft.DotNet.HotReload.WebAssembly.Browser.dllwere not copied to the right directories.Reenables WASM Hot Reload tests in dotnet-watch test suite.