Don't ignore .e2e/ directories in gitignore template#52663
Merged
baronfel merged 1 commit intodotnet:mainfrom Jan 29, 2026
Merged
Don't ignore .e2e/ directories in gitignore template#52663baronfel merged 1 commit intodotnet:mainfrom
baronfel merged 1 commit intodotnet:mainfrom
Conversation
… to end test frameworks
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the dotnet new gitignore template to avoid ignoring directories that end in .e2e (commonly used for end-to-end test folders), while still ignoring .e2e trace files.
Changes:
- Add a negated ignore rule to re-include
*.e2e/directories after the existing*.e2eignore pattern. - Update the integration test approval snapshot to match the new template output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
template_feed/Microsoft.DotNet.Common.ItemTemplates/content/Gitignore/.gitignore |
Adds !*.e2e/ to ensure .e2e directories aren’t ignored by the template. |
test/dotnet-new.IntegrationTests/Approvals/AllCommonItemsCreate.-o#dotnet-gitignore-file#-n#item.verified/dotnet-gitignore-file/.gitignore |
Updates the approved output to reflect the template change. |
baronfel
approved these changes
Jan 23, 2026
This was referenced Jan 23, 2026
Member
|
/ba-g templating known issues |
MichaelSimons
pushed a commit
to MichaelSimons/sdk
that referenced
this pull request
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a negation to avoid gitignore-ing *.e2e/ directories, as that's a common suffix for end-to-end test frameworks. Here's some in-the-wild examples today that would be impacted without this fix: https://github.com/search?q=path%3A.e2e%2F&type=code