Merged
Conversation
1af1c1c to
63e8f65
Compare
63e8f65 to
1d5ecb2
Compare
8280b19 to
49c0774
Compare
Member
Author
|
@MiYanni ptal |
joeloff
reviewed
Jan 8, 2026
MiYanni
approved these changes
Jan 8, 2026
| namespace Microsoft.DotNet.Cli.Commands.BuildServer; | ||
|
|
||
| internal static class BuildServerCommandDefinition | ||
| internal sealed class BuildServerCommandDefinition : Command |
Member
There was a problem hiding this comment.
Maybe this is me just noticing it now, but a CommandDefinition derives from Command? I guess my natural expectation is that only Commands derive from Command. Maybe it would make sense to rename Command to CommandDefinition and CommandBase to Command?
Member
Author
There was a problem hiding this comment.
The CLI uses ambiguous names. There are multiple "Command" types. This one is System.CommandLine.Command.
There is Utils.Command and also CommandBase. These are used for command implementations. I can follow up and do some renames of the latter two to clean it up later on.
joeloff
reviewed
Jan 8, 2026
This was referenced Jan 28, 2026
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More refactoring towards pattern established by #52137.
The only remaining commands that need work are
nugetandnew.