Merged
Conversation
5 tasks
This was referenced Dec 13, 2025
…essing their subcommands, options and arguments
Member
Author
MiYanni
approved these changes
Dec 19, 2025
This was referenced Jan 5, 2026
Merged
This was referenced Jan 28, 2026
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move command completion configuration from definitions to implementations. Completion is not needed for command line parsing.
The completion often depends on the implementation of the command (e.g. NuGet package downloader, etc.).
The last commit switches the affected commands to a new pattern: instead of definitions being static classes and arguments, options and subcommands stored in static fields we instantiate command definitions.
This allows us to use inheritance for similar command definitions (e.g.
package addandadd package) and access their options/arguments in a strongly typed manner.Will move all commands to the new pattern in follow up PRs.