[dotnet-run] fix logging and `Restore` for device selection by jonathanpeppers · Pull Request #52113 · dotnet/sdk

jonathanpeppers · 2025-12-10T17:36:56Z

c164a9b is mostly working with two issues I've discovered while testing:

If ComputeAvailableDevices requires Restore to have run (which is actually the case for iOS and Android), dotnet run would fail unless you did an explicit dotnet restore first:

D:\src\helloandroid> D:\src\dotnet\sdk\artifacts\bin\redist\Debug\dotnet\dotnet.exe run -bl
  failed with 1 error(s) (0.1s)
  D:\src\dotnet\sdk\artifacts\bin\redist\Debug\dotnet\sdk\11.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1004: Assets file 'D:\src\helloandroid\obj\project.assets.json' not found. Run a NuGet package restore to generate this file.

We can test this by changing DotnetRunDevices.csproj:

<Target Name="ComputeAvailableDevices" DependsOnTargets="ResolveFrameworkReferences">

Doing an explicit Restore step before ComputeAvailableDevices resolves this.

We were not passing all loggers to ProjectInstance.Build() calls in RunCommandSelector, so no logging output was shown during device computation. This is now fixed by creating a fresh console logger each time we call Build().

I tested this manually with a console app with a ComputeAvailableDevices target and a lengthy sleep:

helloconsole                 ComputeAvailableDevices (9.1s)

baronfel · 2025-12-10T17:38:56Z

src/Cli/dotnet/Commands/Run/RunCommand.cs

+                    // If the device added a RuntimeIdentifier, we need to re-restore with that RID
+                    // because the previous restore (if any) didn't include it


this is only true if that runtime identifier isn't already part of the RuntimeIdentifiers list, no?

~~Just tested it, I think we can take this out. 👍~~

Once I fixed the bug copilot had found, it is needed in a test that selects:

<Devices Include="test-device-1" Description="Test Device 1" Type="Emulator" Status="Online" RuntimeIdentifier="$(NETCoreSdkRuntimeIdentifier)" />

Error is:

Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1047: Assets file 'D:\src\dotnet\sdk\artifacts\tmp\Debug\testing\ItAutoSelects---A128676A\obj\project.assets.json' doesn't have a target for 'net10.0/win-x64'. Ensure that restore has run and that you have included 'net10.0' in the TargetFrameworks for your project. You may also need to include 'win-x64' in your project's RuntimeIdentifiers.

I think this could actually happen on iOS or Android if you build without a RID and then select a device.

c164a9b is mostly working with two issues I've discovered while testing: 1. If `ComputeAvailableDevices` requires `Restore` to have run (which is actually the case for iOS and Android), `dotnet run` would fail unless you did an explicit `dotnet restore` first: D:\src\helloandroid> D:\src\dotnet\sdk\artifacts\bin\redist\Debug\dotnet\dotnet.exe run -bl failed with 1 error(s) (0.1s) D:\src\dotnet\sdk\artifacts\bin\redist\Debug\dotnet\sdk\11.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1004: Assets file 'D:\src\helloandroid\obj\project.assets.json' not found. Run a NuGet package restore to generate this file. We can test this by changing `DotnetRunDevices.csproj`: <Target Name="ComputeAvailableDevices" DependsOnTargets="ResolveFrameworkReferences"> Doing an explicit `Restore` step before `ComputeAvailableDevices` resolves this. 2. We were not passing loggers `ProjectInstance.Build()` calls in `RunCommandSelector`, so no logging output was shown during device computation. This is now fixed by creating a fresh console logger each time we call `Build()`. I tested this manually with a console app with a `ComputeAvailableDevices` target and a lengthy sleep: helloconsole ComputeAvailableDevices (9.1s)

jonathanpeppers · 2025-12-10T19:22:28Z

There were some full framework tests that seem unrelated:

EXEC : error : Could not read the Windows SDK's Platform.xml at C:\Program Files (x86)\Windows Kits\10\Platforms\UAP\10.0.19041.0\Platform.xml [C:\h\w\A1B308E0\t\dotnetSdkTests\qionsq55.0dh\ManagedWinRTC---79256FB9\ManagedWinRTComponent\ManagedWinRTComponent.csproj]

I reran, to just see if that helps.

baronfel · 2025-12-10T19:30:16Z

@jonathanpeppers I've been seeing that one too on unrelated things - @dotnet/domestic-cat do you know if there's a known build issue about this and/or something we need to get someone to look at?

Copilot

Pull request overview

This PR fixes two issues in the dotnet run device selection feature: (1) adding explicit Restore before ComputeAvailableDevices when the target depends on restored assets (like ResolveFrameworkReferences for iOS/Android), and (2) ensuring MSBuild logging output is shown during device computation by passing loggers to all ProjectInstance.Build() calls.

Key Changes:

RunCommandSelector now performs Restore before computing available devices (unless --no-restore is specified) and tracks whether restore was performed to avoid redundant operations
MSBuild loggers (console and binary) are now passed to all Build() calls through a new GetLoggers() method
Test project updated to simulate real-world scenario where ComputeAvailableDevices depends on ResolveFrameworkReferences

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
test/TestAssets/TestProjects/DotnetRunDevices/DotnetRunDevices.csproj	Added `DependsOnTargets="ResolveFrameworkReferences"` to `ComputeAvailableDevices` target to test restore requirement
src/Cli/dotnet/Commands/Run/RunCommandSelector.cs	Added restore logic before device computation, logger support via `GetLoggers()` method, and `restoreWasPerformed` tracking parameter
src/Cli/dotnet/Commands/Run/RunCommand.cs	Added `_restoreDoneForDeviceSelection` field and logic to skip redundant restore in build phase when already performed during device selection

src/Cli/dotnet/Commands/Run/RunCommandSelector.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

c164a9b is mostly working with two issues I've discovered while testing: 1. If `ComputeAvailableDevices` requires `Restore` to have run (which is actually the case for iOS and Android), `dotnet run` would fail unless you did an explicit `dotnet restore` first: D:\src\helloandroid> D:\src\dotnet\sdk\artifacts\bin\redist\Debug\dotnet\dotnet.exe run -bl failed with 1 error(s) (0.1s) D:\src\dotnet\sdk\artifacts\bin\redist\Debug\dotnet\sdk\11.0.100-dev\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1004: Assets file 'D:\src\helloandroid\obj\project.assets.json' not found. Run a NuGet package restore to generate this file. We can test this by changing `DotnetRunDevices.csproj`: <Target Name="ComputeAvailableDevices" DependsOnTargets="ResolveFrameworkReferences"> Doing an explicit `Restore` step before `ComputeAvailableDevices` resolves this. 2. We were not passing loggers `ProjectInstance.Build()` calls in `RunCommandSelector`, so no logging output was shown during device computation. This is now fixed by creating a fresh console logger each time we call `Build()`. I tested this manually with a console app with a `ComputeAvailableDevices` target and a lengthy sleep: helloconsole ComputeAvailableDevices (9.1s)

Backports these that are already in main/.NET 11: * #51914 * #52113 * #52046

baronfel reviewed Dec 10, 2025

View reviewed changes

baronfel approved these changes Dec 10, 2025

View reviewed changes

jonathanpeppers force-pushed the dev/peppers/Restore-ComputeAvailableDevices branch from ca5a917 to 880d09a Compare December 10, 2025 17:47

jonathanpeppers mentioned this pull request Dec 10, 2025

[Epic] vibe-coding .NET MAUI apps works out of the box dotnet/maui#32967

Open

51 tasks

jonathanpeppers marked this pull request as ready for review December 10, 2025 19:21

jonathanpeppers requested review from MiYanni and Copilot December 10, 2025 19:21

Copilot started reviewing on behalf of jonathanpeppers December 10, 2025 19:22 View session

Copilot AI reviewed Dec 10, 2025

View reviewed changes

src/Cli/dotnet/Commands/Run/RunCommandSelector.cs Outdated Show resolved Hide resolved

jonathanpeppers and others added 2 commits December 10, 2025 13:48

Apply suggestion from @Copilot

7a34939

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update RunCommand.cs

7b844f4

build-analysis bot mentioned this pull request Dec 10, 2025

Could Not Resolve SDK - repo testfx issue #51530

Open

MiYanni approved these changes Dec 11, 2025

View reviewed changes

Merge branch 'main' into dev/peppers/Restore-ComputeAvailableDevices

d92085d

jonathanpeppers enabled auto-merge (squash) December 11, 2025 21:47

jonathanpeppers merged commit 49c0d73 into main Dec 11, 2025
26 checks passed

jonathanpeppers deleted the dev/peppers/Restore-ComputeAvailableDevices branch December 11, 2025 21:51

dotnet-maestro bot mentioned this pull request Dec 12, 2025

[main] Source code updates from dotnet/sdk dotnet/dotnet#3754

Merged

jonathanpeppers mentioned this pull request Jan 21, 2026

[release/10.0.3xx] backport mobile changes for dotnet run #52608

Merged

jonathanpeppers added a commit that referenced this pull request Jan 23, 2026

[release/10.0.3xx] backport mobile changes for dotnet run (#52608)

dd7c083

Backports these that are already in main/.NET 11: * #51914 * #52113 * #52046

This was referenced Feb 12, 2026

[release/10.0.3xx] Source code updates from dotnet/sdk dotnet/dotnet#4826

Merged

[main] Source code updates from dotnet/sdk dotnet/dotnet#4837

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dotnet-run] fix logging and `Restore` for device selection#52113

[dotnet-run] fix logging and `Restore` for device selection#52113
jonathanpeppers merged 4 commits intomainfrom
dev/peppers/Restore-ComputeAvailableDevices

jonathanpeppers commented Dec 10, 2025 •

edited

Loading

Uh oh!

baronfel Dec 10, 2025

Uh oh!

jonathanpeppers Dec 10, 2025 •

edited

Loading

Uh oh!

jonathanpeppers Dec 10, 2025

Uh oh!

jonathanpeppers commented Dec 10, 2025

Uh oh!

baronfel commented Dec 10, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		// If the device added a RuntimeIdentifier, we need to re-restore with that RID
		// because the previous restore (if any) didn't include it

Conversation

jonathanpeppers commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

baronfel Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

jonathanpeppers Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonathanpeppers Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

jonathanpeppers commented Dec 10, 2025

Uh oh!

baronfel commented Dec 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonathanpeppers commented Dec 10, 2025 •

edited

Loading

jonathanpeppers Dec 10, 2025 •

edited

Loading