Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the trusted roots configuration as part of the May 2025 CTL update, including changes to test baselines and certificate data.
- Adds new certificate fingerprint entries for IdenTrust Commercial Root CA 1, AAA Certificate Services, and GlobalSign Root CA in timestamping tests.
- Adds a matching IdenTrust Commercial Root CA 1 entry in the code signing tests.
- Introduces a new certificate block in the trusted roots PEM file to support the updated CTL.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/trustedroots.Tests/GivenTimestampingCtlFile.cs | Added new InlineData entries for additional certificate fingerprints. |
| test/trustedroots.Tests/GivenCodeSigningCtlFile.cs | Introduced a new InlineData entry to include IdenTrust Commercial Root CA 1. |
| src/Layout/redist/trustedroots/timestampctl.pem | Inserted a new certificate block to update the trusted certificate list. |
Nigusu-Allehu
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #49267.
This is the May 2025 update from the Microsoft Trusted Root Program team.
I also updated test baselines.
CC @aortiz-msft, @dotnet/nuget-team