Skip to content

MSBuild terminal logger enamblement.#34606

Merged
rokonec merged 4 commits intorelease/8.0.1xx-rc1from
rokonec/msbuild-tl-enablement
Aug 16, 2023
Merged

MSBuild terminal logger enamblement.#34606
rokonec merged 4 commits intorelease/8.0.1xx-rc1from
rokonec/msbuild-tl-enablement

Conversation

@rokonec
Copy link
Copy Markdown
Member

@rokonec rokonec commented Aug 14, 2023

Fixes: part of dotnet/msbuild#9063

Changes done:

  • prepare for easy enablement in dotnet 9
  • support new msbuild logging configuration telemetry
  • minor refactoring

MSBuild logging configuration telemetry.
Comment thread src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs Outdated
Copy link
Copy Markdown
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs SDK approval

Comment thread src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs Outdated
Comment thread src/Cli/Microsoft.DotNet.Cli.Utils/MSBuildForwardingAppWithoutLogging.cs Outdated
…Logging.cs

Co-authored-by: Rainer Sigwald <raines@microsoft.com>
@baronfel baronfel changed the base branch from main to release/8.0.1xx-rc1 August 15, 2023 20:25
@baronfel
Copy link
Copy Markdown
Member

Retargeted to the rc1 branch now that it's been created. Once this merges, we'll need an explicit backport to release/8.0.1xx as well (no auto-codeflow from RC1 to stable).

Copy link
Copy Markdown
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock merge once the env var rename is made.

@rokonec rokonec merged commit 1bfb668 into release/8.0.1xx-rc1 Aug 16, 2023
@rokonec rokonec deleted the rokonec/msbuild-tl-enablement branch August 16, 2023 15:19
rokonec added a commit that referenced this pull request Aug 16, 2023
Co-authored-by: Chet Husk <baronfel@users.noreply.github.com>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants