Skip to content

Fix building VB WPF project#3456

Merged
nguerrera merged 1 commit into
dotnet:masterfrom
nguerrera:vb-wpf
Jul 25, 2019
Merged

Fix building VB WPF project#3456
nguerrera merged 1 commit into
dotnet:masterfrom
nguerrera:vb-wpf

Conversation

@nguerrera

Copy link
Copy Markdown
Contributor

The target to select the VB runtime DLL from ReferencePath was not being run when compiling the temporary project for a XAML build.

Fix #3450

@nguerrera nguerrera requested a review from a team July 24, 2019 18:01
@nguerrera

Copy link
Copy Markdown
Contributor Author

FYI, @vatsan-madhavan

The target to select the VB runtime DLL from ReferencePath was not
being run when compiling the temporary project for a XAML build.
@nguerrera nguerrera added this to the 3.0.1xx milestone Jul 24, 2019
@livarcocc

Copy link
Copy Markdown
Contributor

These have all passed as well but github is failing to update status. Feel free to merge @nguerrera

@nguerrera nguerrera merged commit 6b26f61 into dotnet:master Jul 25, 2019
@nguerrera nguerrera deleted the vb-wpf branch July 25, 2019 13:44
dsplaisted added a commit to dsplaisted/sdk that referenced this pull request Feb 19, 2020
Enable Sdl Validation in official builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WPF for VB build failed with error BC2017: could not find library 'Microsoft.VisualBasic.dll'

4 participants