Skip to content

Don't reference assemblies from targeting pack with ReferencedByDefault="false"#3455

Merged
dsplaisted merged 4 commits into
dotnet:masterfrom
dsplaisted:referencebydefault
Jul 25, 2019
Merged

Don't reference assemblies from targeting pack with ReferencedByDefault="false"#3455
dsplaisted merged 4 commits into
dotnet:masterfrom
dsplaisted:referencebydefault

Conversation

@dsplaisted

Copy link
Copy Markdown
Member

@dsplaisted dsplaisted requested a review from nguerrera July 24, 2019 14:02
@dsplaisted

Copy link
Copy Markdown
Member Author

Some PreserveCompilationContext tests are failing because they expect the LanguageVersion to be empty or "preview", but it's now set to 7.3 with the stage 0 update. Is this expected?

@livarcocc @agocke @nguerrera

@nguerrera

Copy link
Copy Markdown
Contributor

This is expected.

@nguerrera

Copy link
Copy Markdown
Contributor

What's the tfm?

@nguerrera

Copy link
Copy Markdown
Contributor

Please don't change it to expect any specific default value. I would only assert a value if we have the property explicitly set in test project. Otherwise, Roslyn owns the policy and can set it to whatever it deems appropriate.

@dsplaisted dsplaisted merged commit 33a21e5 into dotnet:master Jul 25, 2019
dsplaisted pushed a commit to dsplaisted/sdk that referenced this pull request Feb 19, 2020
…ld 20191104.2 (dotnet#3455)

- Microsoft.WindowsDesktop.App - 5.0.0-alpha.1.19554.2
dsplaisted pushed a commit to dsplaisted/sdk that referenced this pull request Feb 19, 2020
* master: (27 commits)
  Add DOTNET_ROOT to tests and fix dogfood script
  Remove duplicated key
  Installation script update (dotnet#13030)
  Use scanelf over ldconfig on musl-libc distros (dotnet#12642)
  Allow list more properties (dotnet#3459)
  Update dependencies from https://github.com/mono/linker build 20191106.1 (dotnet#3476)
  [master] Update dependencies from aspnet/websdk (dotnet#3466)
  Update dependencies from https://github.com/aspnet/AspNetCore build 20191105.3 (dotnet#3473)
  Update dependencies from https://github.com/dotnet/windowsdesktop build 20191105.1 (dotnet#3469)
  Update dependencies from https://github.com/dotnet/arcade build 20191104.3 (dotnet#3465)
  Update dependencies from https://github.com/aspnet/websdk build 20191103.2 (dotnet#3454)
  [master] Update dependencies from dotnet/arcade (dotnet#3416)
  Update dependencies from https://github.com/aspnet/AspNetCore build 20191104.3 (dotnet#3458)
  Update dependencies from https://github.com/dotnet/templating build 20191104.1 (dotnet#3457)
  [master] Update dependencies from Microsoft/msbuild (dotnet#3423)
  [master] Update dependencies from aspnet/AspNetCore (dotnet#3440)
  Update dependencies from https://github.com/dotnet/windowsdesktop build 20191104.2 (dotnet#3455)
  [master] Update dependencies from dotnet/core-setup (dotnet#3445)
  Update dependencies from https://github.com/dotnet/windowsdesktop build 20191102.6 (dotnet#3446)
  Update dependencies from https://github.com/aspnet/websdk build 20191102.2 (#3444)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants