Skip to content

Support automatic Link metadata for Page and Resource items#3390

Merged
dsplaisted merged 1 commit into
dotnet:masterfrom
dsplaisted:automatic-link-for-resource-and-page
Jul 23, 2019
Merged

Support automatic Link metadata for Page and Resource items#3390
dsplaisted merged 1 commit into
dotnet:masterfrom
dsplaisted:automatic-link-for-resource-and-page

Conversation

@dsplaisted

Copy link
Copy Markdown
Member

Fix #2697

@dsplaisted dsplaisted requested a review from a team July 3, 2019 05:46
@dsplaisted

Copy link
Copy Markdown
Member Author

@vatsan-madhavan

@vatsan-madhavan

Copy link
Copy Markdown
Member

Does this have the potential to decouple Foo.xaml and Foo.xaml.cs in the VS UI?

For eg, will this impact the DependentUpon relationship between a Compile item and a .xaml file in the UI?

@dsplaisted

Copy link
Copy Markdown
Member Author

Does this have the potential to decouple Foo.xaml and Foo.xaml.cs in the VS UI?

For eg, will this impact the DependentUpon relationship between a Compile item and a .xaml file in the UI?

@davkean @drewnoakes Can you comment on this?

@davkean

davkean commented Jul 9, 2019

Copy link
Copy Markdown
Member

This doesn't affect items in the project cone and only affects those files outside of the project that have opt'd into LinkBase. I would expect that nesting still kicks in, even in that case.

@vatsan-madhavan

Copy link
Copy Markdown
Member

thx - lgtm!

@dsplaisted

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@dsplaisted dsplaisted merged commit 7ee4c2a into dotnet:master Jul 23, 2019
dsplaisted pushed a commit to dsplaisted/sdk that referenced this pull request Feb 19, 2020
….7 (dotnet#3390)

- Microsoft.DotNet.Cli.Runtime - 3.1.100-preview2.19530.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic Link generation from LinkBase does not work for Page, Resource items

3 participants