Merged
Conversation
Merged
|
Consider: Test timeouts have been useful in capturing product code delays. That said, I am not familiar with the sensitivity of the scenario to recommend a replacement time that makes sense for these scenarios. 5 minutes for browser launch seems like a good ceiling value. |
arunchndr
approved these changes
Sep 6, 2022
Member
Author
|
I'd prefer we have dedicated performance tests for doing that instead of timeouts in tests that run on random VMs that do not use dedicated resources and thus their execution time varies a lot. |
lbussell
pushed a commit
to lbussell/dotnet-sdk
that referenced
this pull request
Sep 7, 2022
* Remove timeouts from tests * Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timeouts are arbitrary and make tests flaky.