Use architecture specific DOTNET_ROOT variable name#27566
Use architecture specific DOTNET_ROOT variable name#27566tmat merged 5 commits intodotnet:release/7.0.2xxfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
9ae8004 to
85fe4fc
Compare
|
@mateoatr @vitek-karas PTAL |
That comment was mainly about the case where both architectures are known and the SDK architecture is different from the target architecture - in that case SDK should not set anything, since it doesn't know anything about the target's architecture situation on the machine - thus it should fallback to existing state on the machine to figure it out. I don't know what is the behavior for "dotnet watch" in this case. The logic should be:
I don't feel strongly about the behavior when the target architecture is unknown (I think and hope that it's rare anyway), but since "dotnet run" already defaults to "assume SDK's architecture", then I guess "dotnet watch" should be consistent. |
|
@MarcoRossignoli as an FYI, since he implemented (and maintains) a similar logic in "dotnet test". |
|
@dotnet/dotnet-cli PTAL |
|
@tmat the linked issue is from a year ago and listed for .net 8. Is this not too risky to take in rc2 at this time? |
|
@marcpopMSFT I'm fine moving to .NET 8. Note though that this also corrects the parsing of RID in |
|
cc: @Evangelink |
|
Moving to main. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@dsplaisted Rebased to 7.0.2xx |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@tmat Looks like some of the new EnvironmentVariableNamesTests are failing. |
Corrects parsing of runtime identifier added by #19860 and reuses the code in dotnet watch to do the same.
Other than parsing the rid the behavior of #19860 is preserved. However, it doesn't seem consistent with #19743 (comment) in the case the architecture specified in rid is unknown. The implementation in this case sets DOTNET_ROOT variable, while it seems it shouldn't since an unknown architecture doesn't match the current architecture.
Implements dotnet/aspnetcore#35793